Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Bump @nextcloud/vue + @nextcloud/dialogs + @nextcloud/calendar-availability-vue #40692

Merged
merged 5 commits into from Oct 6, 2023
Merged

chore: Bump @nextcloud/vue + @nextcloud/dialogs + @nextcloud/calendar-availability-vue #40692

merged 5 commits into from Oct 6, 2023

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Sep 29, 2023 •
edited

Summary

  • Bump @nextcloud/vue + @nextcloud/dialogs + @nextcloud/calendar-availability-vue
  • Adapt to breaking changes
  • Fix acceptance tests

To Do

  • Resolve bundler CI errors

Checklist

@Pytal Pytal added the 2. developing Work in progress label Sep 29, 2023
@Pytal Pytal added this to the Nextcloud 28 milestone Sep 29, 2023
@Pytal Pytal self-assigned this Sep 29, 2023
This was referenced Sep 29, 2023
Closed
Closed
Closed
@st3iny
Copy link
Member

st3iny commented Oct 5, 2023 •
edited

ERROR in ./node_modules/@nextcloud/dialogs/dist/chunks/FilePicker-fe2ce33f.mjs 155:217-219
export 'NcDatetime' (imported as 'ee') was not found in '@nextcloud/vue'

It seems that dialogs (and probably any other dependency that makes use of nextcloud/vue) needs to updated as well. It should be NcDateTime.

Ref nextcloud-libraries/nextcloud-vue#4560

@ShGKme
Copy link
Contributor

ShGKme commented Oct 5, 2023

Both @nextcloud/calendar-availability-vue and @nextcloud/dialogs updates were published, so we can upgrade @nextcloud/vue now

@Pytal Pytal force-pushed the deps/nextcloud/vue-8.0.0-beta.7 branch from 4eec177 to e2ced9d Compare October 5, 2023 16:39
@Pytal Pytal marked this pull request as ready for review October 5, 2023 16:41
@Pytal Pytal added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Oct 5, 2023
@Pytal Pytal changed the title chore: Bump @nextcloud/vue to v8-beta.7 chore: Bump @nextcloud/vue + @nextcloud/dialogs + @nextcloud/calendar-availability-vue Oct 5, 2023
ShGKme
ShGKme approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@ShGKme
Copy link
Contributor

ShGKme commented Oct 6, 2023

crying

Working under a fix for tests

@ShGKme ShGKme mentioned this pull request Oct 6, 2023
Merged
@Pytal Pytal mentioned this pull request Oct 6, 2023
Merged
2 tasks
@Pytal
chore: Bump @nextcloud/vue + @nextcloud/dialogs + @nextcloud/calendar…
44ddd91 
…-availability-vue

Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
chore: Adapt to breaking DateTime rename
675feb9 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
fix(acceptance): Locate contacts menu button
744a7e2 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
chore: compile assets
4f1751f 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal force-pushed the deps/nextcloud/vue-8.0.0-beta.7 branch from 0cd8007 to 4f1751f Compare October 6, 2023 21:43
@Pytal
fix(ci): Update dav snapshot
ca43254 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 6, 2023
@Pytal Pytal merged commit 5979651 into master Oct 6, 2023
39 of 40 checks passed
@Pytal Pytal deleted the deps/nextcloud/vue-8.0.0-beta.7 branch October 6, 2023 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@JuliaKirschenheuter JuliaKirschenheuter JuliaKirschenheuter approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@ShGKme ShGKme ShGKme approved these changes

Assignees

@Pytal Pytal

Labels
4. to release Ready to be released and/or waiting for tests to finish dependencies
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Pytal @st3iny @ShGKme @susnux @JuliaKirschenheuter @skjnldsv