Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BITV] 9.3.3.2/8.2 - The "Add group" input field does not have a visual label, it only has a placeholder element. (1) #37090

Closed
4 tasks done
AndyScherzinger opened this issue Mar 7, 2023 · 7 comments
Assignees
Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility
Milestone

Comments

@Pytal
Copy link
Member

Pytal commented Aug 18, 2023

Would need a redesign of NcAppNavigationNewItem

image

Could be NcActions with NcActionInput inside and a visible label @nimishavijay?

@JuliaKirschenheuter
Copy link
Contributor

@marcoambrosini?

@marcoambrosini
Copy link
Member

marcoambrosini commented Aug 29, 2023

Agree with @Pytal, we could use NcAppnavigationCaption which comes with an NcActionMenu on the right.
This is exactly what we do for contacts groups.

Screenshot 2023-08-29 at 10 49 50

And we should probably deprecate the NcAppNavigationNew component. cc @skjnldsv what are your thoughts on that?

@skjnldsv
Copy link
Member

cc @skjnldsv what are your thoughts on that?

None :)
As long as the component code and logic make sense, it doesn't trubles me.
Nonetheless, using an NcAppnavigationCaption seems counter intuitive. SO maybe there can just be a bit of change in the NcAppNavigationNew to have it use the NcAppnavigationCaption 🤷

@Pytal
Copy link
Member

Pytal commented Aug 30, 2023

None :) As long as the component code and logic make sense, it doesn't trubles me. Nonetheless, using an NcAppnavigationCaption seems counter intuitive. SO maybe there can just be a bit of change in the NcAppNavigationNew to have it use the NcAppnavigationCaption 🤷

Probably for a separate issue @skjnldsv ?

@Pytal Pytal added 3. to review Waiting for reviews and removed 1. to develop Accepted and waiting to be taken care of labels Aug 30, 2023
@Pytal
Copy link
Member

Pytal commented Oct 7, 2023

While working on #40110 which uses NcAppNavigationCaption with actions I found a regression from #40576 which removes pointer events making the actions unclickable and changes the styling

image

Can you scope the .app-navigation-caption styles to non-Vue app navigation containers again @JuliaKirschenheuter ?

@AndyScherzinger AndyScherzinger added this to the Nextcloud 28 milestone Oct 7, 2023
@Pytal
Copy link
Member

Pytal commented Oct 10, 2023

👆 fixed in #40858

@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 11, 2023
@Pytal Pytal closed this as completed Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility
Projects
None yet
Development

No branches or pull requests

5 participants