Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BITV]: NcSelect improvements #40697

Closed
JuliaKirschenheuter opened this issue Sep 29, 2023 · 1 comment · Fixed by nextcloud-libraries/nextcloud-vue#4762
Closed

[BITV]: NcSelect improvements #40697

JuliaKirschenheuter opened this issue Sep 29, 2023 · 1 comment · Fixed by nextcloud-libraries/nextcloud-vue#4762
Assignees
Labels

Comments

@JuliaKirschenheuter
Copy link
Contributor

JuliaKirschenheuter commented Sep 29, 2023

This is accessibility issue.

There are several point to improve:

  1. Preselected time zone (Europe - Amsterdam) have not enough contrast and seems like
    Screenshot from 2023-09-29 09-22-10

  2. Group item like "Africa" have not enough contrast and is not recognizable even if it is disabled item.
    Screenshot from 2023-09-29 09-27-47

  3. Aria-label of combobox is "search for option" and have to be instead "Search for time zone"
    Screenshot from 2023-09-29 09-46-30

  4. strong timezone have to be a label for Select
    Screenshot from 2023-09-29 09-48-36

@JuliaKirschenheuter JuliaKirschenheuter added enhancement 1. to develop Accepted and waiting to be taken care of labels Sep 29, 2023
@susnux susnux self-assigned this Oct 5, 2023
@susnux
Copy link
Contributor

susnux commented Oct 5, 2023

1. Preselected time zone (Europe - Amsterdam) have not enough contrast and seems like
2. Group item like "Africa" have not enough contrast and is not recognizable even if it is disabled item.
3. Aria-label of combobox is "search for option" and have to be instead "Search for time zone"
  • TBD
4. `strong` timezone have to be a label for Select

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants