Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcSelect): Ensure selected option has enough contrast when the menu is opened #4733

Merged
merged 1 commit into from Nov 1, 2023
Merged

fix(NcSelect): Ensure selected option has enough contrast when the menu is opened #4733

merged 1 commit into from Nov 1, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Nov 1, 2023

☑️ Resolves

Make sure the currently active option has still enough contrast when the menu is opened, by dropping the opacity property but using max contrast color.

🖼️ Screenshots

🏚️ Before 🏡 After
before after

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

@susnux
fix(NcSelect): Ensure selected option has enough contrast when the me…
372dedb 
…nu is opened

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added bug Something isn't working 3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities labels Nov 1, 2023
@susnux susnux mentioned this pull request Nov 1, 2023
Closed
szaimen
szaimen approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from the screenshot

@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 1, 2023
@Pytal Pytal merged commit d2d0323 into master Nov 1, 2023
15 checks passed
@Pytal Pytal deleted the fix/nc-select-selected-option-open branch November 1, 2023 17:17
@raimund-schluessler raimund-schluessler added this to the 8.0.0 milestone Nov 2, 2023
@skjnldsv skjnldsv mentioned this pull request Nov 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pytal Pytal Pytal approved these changes

@ShGKme ShGKme ShGKme approved these changes

@szaimen szaimen szaimen approved these changes

@raimund-schluessler raimund-schluessler Awaiting requested review from raimund-schluessler

@JuliaKirschenheuter JuliaKirschenheuter Awaiting requested review from JuliaKirschenheuter

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility Making sure we design for the widest range of people possible, including those who have disabilities bug Something isn't working
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@susnux @Pytal @ShGKme @szaimen @raimund-schluessler