Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NcTimezonePicker): Allow to set ID of inner select component #4734

Merged
merged 1 commit into from Nov 1, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Nov 1, 2023

☑️ Resolves

Allows to the the ID of the inner select so it can be referenced by labels.

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

@susnux susnux added enhancement New feature or request 3. to review Waiting for reviews feature: select Related to the NcSelect* components labels Nov 1, 2023
ShGKme
ShGKme previously requested changes Nov 1, 2023
src/components/NcTimezonePicker/NcTimezonePicker.vue Outdated Show resolved Hide resolved
…able to reference it for labels

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 1, 2023
@Pytal Pytal merged commit 6d55089 into master Nov 1, 2023
15 checks passed
@Pytal Pytal deleted the fix/nc-timezone-picker-allow-uid branch November 1, 2023 17:35
@raimund-schluessler raimund-schluessler added this to the 8.0.0 milestone Nov 2, 2023
@skjnldsv skjnldsv mentioned this pull request Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement New feature or request feature: select Related to the NcSelect* components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants