Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(NcAppContent): add horizontal split layout #5401

Merged
merged 1 commit into from Mar 15, 2024
Merged

feat(NcAppContent): add horizontal split layout #5401

merged 1 commit into from Mar 15, 2024

Conversation

GretaD
Copy link
Contributor

@GretaD GretaD commented Mar 12, 2024 •
edited

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
B A

🚧 Tasks

  • ...

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@GretaD GretaD added enhancement New feature or request 2. developing Work in progress labels Mar 12, 2024
@GretaD GretaD self-assigned this Mar 12, 2024
@GretaD GretaD mentioned this pull request Mar 13, 2024
Merged
4 tasks
@ChristophWurst ChristophWurst marked this pull request as draft March 13, 2024 09:27
@GretaD

This comment was marked as outdated.

Sign in to view
@GretaD
Copy link
Contributor Author

GretaD commented Mar 14, 2024

Screenshot from 2024-03-14 13-20-59

@GretaD GretaD marked this pull request as ready for review March 14, 2024 12:22
@GretaD GretaD added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Mar 14, 2024
@ChristophWurst ChristophWurst added this to the 8.11.0 milestone Mar 14, 2024
ShGKme
ShGKme approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine, only some nitpicks and docs comments.

src/components/NcAppContent/NcAppContent.vue Show resolved Hide resolved
src/components/NcAppContent/NcAppContent.vue Outdated Show resolved Hide resolved
@GretaD
Add horizontal split for appcontent
45792a6 
Signed-off-by: greta <gretadoci@gmail.com>
@GretaD GretaD merged commit ea833ca into master Mar 15, 2024
18 checks passed
@GretaD GretaD deleted the feat/horizontal-split branch March 15, 2024 15:12
@GretaD
Copy link
Contributor Author

GretaD commented Mar 15, 2024

/backport to next

@backportbot backportbot bot mentioned this pull request Mar 15, 2024
Closed
2 tasks
@ShGKme ShGKme changed the title Feat(NcAppContent) Add horizontal split for appcontent feat(NcAppContent): add horizontal split layout Mar 15, 2024
@Antreesy Antreesy mentioned this pull request Mar 15, 2024
Merged
@ShGKme
Copy link
Contributor

ShGKme commented Mar 20, 2024

/backport to next

@backportbot backportbot bot mentioned this pull request Mar 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@ShGKme ShGKme ShGKme approved these changes

@susnux susnux Awaiting requested review from susnux

Assignees

@GretaD GretaD

Labels
3. to review Waiting for reviews enhancement New feature or request
Projects
None yet
Milestone
8.11.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@GretaD @ShGKme @ChristophWurst