Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add horizontal split for mailing list #9462

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

GretaD
Copy link
Contributor

@GretaD GretaD commented Mar 13, 2024

Tasks

  • Add horizontal split

Follow up

    • Increase the number of messages showed by default on vertical and list view, and less on horizontal view

How to reproduce:

  1. Go to app settings
  2. Click horizontal view

For #8309

@GretaD GretaD self-assigned this Mar 13, 2024
@GretaD GretaD marked this pull request as draft March 13, 2024 09:24
@GretaD GretaD removed the request for review from ChristophWurst March 13, 2024 09:25
@GretaD GretaD force-pushed the feat/horizontal-split-layout branch from bc86547 to b66eb53 Compare March 13, 2024 09:26
@GretaD GretaD marked this pull request as ready for review March 14, 2024 12:59
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great on desktop 👍

My only request: allow the thread list to be higher than ~40%. If the screen is big, I want to use 2/3 for the list and 1/3 for the message.


Does not work on mobile

image

@GretaD
Copy link
Contributor Author

GretaD commented Mar 14, 2024

Does not work on mobile

thats because of npm link, if you copy /dist from nextcloud-vue to node_modules/@nextcloud/vue in Mail it will work fine. I had the same issue with no-split, and Grigorii mention that its because of npm link

package.json Outdated Show resolved Hide resolved
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

src/components/AppSettingsMenu.vue Outdated Show resolved Hide resolved
src/components/Mailbox.vue Outdated Show resolved Hide resolved
@GVodyanov
Copy link
Contributor

After playing around a bit with it a request I would have is some way to be able to close the split, because say I want my full page email list after reading an email (useful for searching). Currently, I don't see any way to do this.

@GretaD
Copy link
Contributor Author

GretaD commented Mar 18, 2024

After playing around a bit with it a request I would have is some way to be able to close the split, because say I want my full page email list after reading an email (useful for searching). Currently, I don't see any way to do this.

Im not sure if i understand what you mean, if you want to go back to full list of vertical split, you go back to app settings and switch to a different layout.

@GVodyanov

This comment was marked as off-topic.

@GretaD
Copy link
Contributor Author

GretaD commented Mar 18, 2024

After playing around a bit with it a request I would have is some way to be able to close the split, because say I want my full page email list after reading an email (useful for searching). Currently, I don't see any way to do this.

ah, we have already done the design part of the layouts and the design team wants the buttons only on app settings.

@GVodyanov GVodyanov self-requested a review March 18, 2024 16:41
Copy link
Contributor

@GVodyanov GVodyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

horizontal mail split

Test on Firefox (v121), seems to work well enough, stops showing on mobile (with nextcloud-vue v8.11), but I assume that's intentional.

@GretaD GretaD force-pushed the feat/horizontal-split-layout branch from 0309db3 to e963790 Compare March 20, 2024 09:44
Signed-off-by: greta <gretadoci@gmail.com>
@ChristophWurst ChristophWurst merged commit 884a4da into main Mar 20, 2024
36 checks passed
@ChristophWurst ChristophWurst deleted the feat/horizontal-split-layout branch March 20, 2024 10:05
@ratermir
Copy link

Hello, I really appreciate the horizontal split of screen, great work. The whole mail app seems to be perfectly usable in the version 3.6. Only I'd prefer bigger part of mail list (now it is approx. 40%, which is too few). By me it could be from 20% to 80% of screen space - let it on the user whot he/she want to see.

@GretaD
Copy link
Contributor Author

GretaD commented Apr 17, 2024

Hello, I really appreciate the horizontal split of screen, great work. The whole mail app seems to be perfectly usable in the version 3.6. Only I'd prefer bigger part of mail list (now it is approx. 40%, which is too few). By me it could be from 20% to 80% of screen space - let it on the user whot he/she want to see.

yes, its on our plans to change this soon because of the reasons you are mentioning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants