Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NcResource): use RouterLink where possible for internal shared resources #5282

Merged
merged 1 commit into from Feb 22, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Feb 21, 2024

☑️ Resolves

🖼️ Screenshots

Screencast.from.21.02.2024.17.44.23.webm

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

…sources

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy added bug Something isn't working 3. to review Waiting for reviews feature: related resources panel Related to the NcRelatedResourcesPanel component labels Feb 21, 2024
@Antreesy Antreesy added this to the 8.7.2 milestone Feb 21, 2024
@Antreesy Antreesy self-assigned this Feb 21, 2024
@Antreesy Antreesy merged commit 26a086c into master Feb 22, 2024
18 checks passed
@Antreesy Antreesy deleted the fix/5246/ncresource-internal-link branch February 22, 2024 08:41
@Antreesy
Copy link
Contributor Author

/backport to next

Copy link

backportbot bot commented Feb 22, 2024

The backport to next failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout next
git pull origin next

# Create the new backport branch
git checkout -b backport/5282/next

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 1f0e98ac

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/5282/next

Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud-libraries:backport/5282/next."}


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working feature: related resources panel Related to the NcRelatedResourcesPanel component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants