NcRelatedResourcesPanel click on resourse within one provider reloads a page

[Antreesy]

Issue description

<NcResource/> renders as a <NcButton/> component with a following prop:

nextcloud-vue/src/components/NcRelatedResourcesPanel/NcResource.vue

Line 28 in a0d0272

:href="url">

which transforms it to a <a/> link. Thus, if you click on a <conversation_name> button inside of Talk app (Shared items tab), it reloads page, instead of switching conversation

Possible solution

<NcButton/> has a support of using <RouterLink/> with to prop, so could be done with a check, that global prop providerId matches with resource field providerId (and matches 'talk', if it's the only case for Talk app)

[Pytal]

Proposed solutions sounds good :)

Would this implementation be useful in files @skjnldsv and deck @juliushaertl as well?

[skjnldsv]

Not sure I get the context? 🤔

[Antreesy]

So, in two words, this component shouldn't reload a page, when click on different conversation:

It is used also only in Deck atm, if I get it correct:
https://github.com/nextcloud/deck/blob/e8dd28752867acde15944e4d00c53caeb6570e3f/src/components/board/SharingTabSidebar.vue#L79

[skjnldsv]

The only thing I could think of is creating a global router that plugs into various apps to see if a clicked link does have a router match somewhere and if so, catch the page refresh. 🤔

[Pytal]

The only thing I could think of is creating a global router that plugs into various apps to see if a clicked link does have a router match somewhere and if so, catch the page refresh. 🤔

The intention was to scope this per app I believe

It is used also only in Deck atm, if I get it correct: nextcloud/deck@e8dd287/src/components/board/SharingTabSidebar.vue#L79

The files panel is registered in the related_resources app itself https://github.com/search?type=code&q=org%3Anextcloud+%22NcRelatedResourcesPanel%22 fyi @Antreesy

[skjnldsv]

The intention was to scope this per app I believe

But the NcResource.vue is standalone, no?
Might be worth thinking about this 🤷

[Antreesy]

The only thing I could think of is creating a global router

If that also helps to cover such app parts and cases, as UnifiedSearch / internal links in Talk messages, I'd like to try it out

Otherwise, and for that particular case, I think, 5 lines of changes locally would be sufficient

[Antreesy]

Fixed by #5282