Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Ensure no double scrollbars for NcDialog and NcAppNavigationSettings #5139

Merged
merged 3 commits into from
Jan 26, 2024
Merged

fix: Ensure no double scrollbars for NcDialog and NcAppNavigationSettings #5139

merged 3 commits into from
Jan 26, 2024

Commits on Jan 26, 2024

  1. fix(NcDialog): Adjust styles to prevent two scrollbars on small screens 

    This also fixes some design issues, we do not want padding or margin on the bottom and right of the content in case of a scrollbar.
When scrolling the scrollbar should be on the very left (not floating in the middle) and the scrolled content should be clipped by the modal container.

Also ensure the dialog name is not overflown by the close button.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
    @susnux
    susnux committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    58fa5e1 View commit details
    Browse the repository at this point in the history

  2. fix(NcModal): Also use more height when window height is small 

    Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
    @susnux
    susnux committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    bb3b25e View commit details
    Browse the repository at this point in the history

  3. fix(NcAppSettingsDialog): Do not enfore element height that causes do… 

    …uble scrollbars

Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Eduardo Morales <emoral435@gmail.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
    @susnux @emoral435
    susnux and emoral435 committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    016ffcf View commit details
    Browse the repository at this point in the history