fix: Ensure no double scrollbars for NcDialog and NcAppNavigationSettings #5139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
bug
susnux
requested review from
JuliaKirschenheuter,
Pytal,
ShGKme,
emoral435,
marcoambrosini and
nimishavijay
ShGKme
approved these changes
Jan 25, 2024
Pytal
approved these changes
Jan 25, 2024
JuliaKirschenheuter
approved these changes
Jan 26, 2024
emoral435
approved these changes
Jan 26, 2024
This also fixes some design issues, we do not want padding or margin on the bottom and right of the content in case of a scrollbar. When scrolling the scrollbar should be on the very left (not floating in the middle) and the scrolled content should be clipped by the modal container. Also ensure the dialog name is not overflown by the close button. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
…uble scrollbars Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de> Co-authored-by: Eduardo Morales <emoral435@gmail.com> Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
Fix [BITV]: settings modal has double scrollbar under some circumstances nextcloud/server#42938
NcDialog:
This also fixes some design issues, we do not want padding or margin on the bottom and right of the content in case of a scrollbar. When scrolling the scrollbar should be on the very left (not floating in the middle) and the scrolled content should be clipped by the modal container.
NcModal:
NcAppNavigationSettings
🖼️ Screenshots
Note the double scrollbars
🏁 Checklist