Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcEmptyContent): Fix regression that changed the color of the description text #4735

Merged
merged 1 commit into from Nov 1, 2023
Merged

fix(NcEmptyContent): Fix regression that changed the color of the description text #4735

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/components/NcEmptyContent/NcEmptyContent.vue
View file
Open in desktop
Expand Up @@ -28,8 +28,8 @@ Providing an icon, name, and a description is strongly advised.

```
<template>
<NcEmptyContent
name="No comments">
<NcEmptyContent name="No comments"
description="Start writing comments and they will appear here.">
<template #icon>
<Comment />
</template>
Expand Down Expand Up @@ -150,7 +150,7 @@ export default {
{{ name }}
</span>
</slot>
<p v-if="hasDescription">
<p v-if="hasDescription" class="empty-content__description">
<!-- @slot Optional formatted description rendered inside a paragraph -->
<slot name="description">
{{ description }}
Expand Down Expand Up @@ -243,6 +243,10 @@ export default {
line-height: 30px;
}

&__description {
color: var(--color-text-maxcontrast);
}

&__action {
margin-top: 8px;

Expand Down