Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcEmptyContent): Fix regression that changed the color of the description text #4735

Merged
merged 1 commit into from Nov 1, 2023
Merged

fix(NcEmptyContent): Fix regression that changed the color of the description text #4735

merged 1 commit into from Nov 1, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Nov 1, 2023

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
Screenshot 2023-11-01 at 17-06-10 Nextcloud Vue Style Guide Screenshot 2023-11-01 at 17-05-52 Nextcloud Vue Style Guide

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

@susnux
fix(NcEmptyContent): Fix regression that changed the color of the des…
d25e345 
…cription text

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added 3. to review Waiting for reviews regression Regression of a previous working feature design Design, UX, interface and interaction design labels Nov 1, 2023
@susnux susnux added the feature: emptycontent Related to the emptycontent component label Nov 1, 2023
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 1, 2023
@Pytal Pytal merged commit e13ede7 into master Nov 1, 2023
15 checks passed
@Pytal Pytal deleted the fix/empty-content-color branch November 1, 2023 17:23
@raimund-schluessler raimund-schluessler added this to the 8.0.0 milestone Nov 2, 2023
@skjnldsv
Copy link
Contributor

skjnldsv commented Nov 3, 2023

Please set appropriate bug or enhancement labels next time 👍

@skjnldsv skjnldsv added the bug Something isn't working label Nov 3, 2023
@skjnldsv skjnldsv mentioned this pull request Nov 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pytal Pytal Pytal approved these changes

@ShGKme ShGKme ShGKme approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@raimund-schluessler raimund-schluessler Awaiting requested review from raimund-schluessler

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

@nimishavijay nimishavijay Awaiting requested review from nimishavijay

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug Something isn't working design Design, UX, interface and interaction design feature: emptycontent Related to the emptycontent component regression Regression of a previous working feature
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

Description of empty content is no longer max-contrast?
5 participants
@susnux @skjnldsv @Pytal @ShGKme @raimund-schluessler