Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcDialog): register components in NcDialogButton #4725

Merged
merged 1 commit into from Oct 31, 2023
Merged

fix(NcDialog): register components in NcDialogButton #4725

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/components/NcDialogButton/NcDialogButton.vue
View file
Open in desktop
Expand Up @@ -44,6 +44,11 @@
export default defineComponent({
name: 'NcDialogButton',

components: {
NcButton,
NcIconSvgWrapper,
},

props: {
/**
* The function that will be called when the button is pressed
Expand Down Expand Up @@ -73,7 +78,7 @@

/**
* The button type, see NcButton
* @values 'primary', 'secondary', 'error', 'warning', 'success'

Check warning on line 81 in src/components/NcDialogButton/NcDialogButton.vue

View workflow job for this annotation

GitHub Actions / eslint 

Invalid JSDoc tag name "values"
*/
type: {
type: String,
Expand All @@ -95,12 +100,7 @@
emit('click', e)
}

return {
NcButton,
NcIconSvgWrapper,

handleClick,
}
return { handleClick }
},
})
</script>