Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcDialog): register components in NcDialogButton #4725

Merged
merged 1 commit into from Oct 31, 2023
Merged

fix(NcDialog): register components in NcDialogButton #4725

merged 1 commit into from Oct 31, 2023

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Oct 31, 2023

@ShGKme
fix(NcDialog): register components in NcDialogButton
49e749c 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme added bug Something isn't working 3. to review Waiting for reviews feature: dialog Related to the dialog component labels Oct 31, 2023
@ShGKme ShGKme added this to the 8.0.0 milestone Oct 31, 2023
@ShGKme ShGKme self-assigned this Oct 31, 2023
@raimund-schluessler
Copy link
Contributor

Didn't I already see two similar PRs? 🙈

@susnux susnux merged commit eeace13 into master Oct 31, 2023
15 checks passed
@susnux susnux deleted the fix/4723/dialog-component-registration branch October 31, 2023 10:44
@skjnldsv skjnldsv mentioned this pull request Nov 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@raimund-schluessler raimund-schluessler raimund-schluessler approved these changes

@Pytal Pytal Awaiting requested review from Pytal

@DorraJaouad DorraJaouad Awaiting requested review from DorraJaouad

Assignees

@ShGKme ShGKme

Labels
3. to review Waiting for reviews bug Something isn't working feature: dialog Related to the dialog component
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

NcDialog/ NcDialogButton - NcButton registration
3 participants
@ShGKme @raimund-schluessler @susnux