Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use vite and vitest for bundling and testing the package #705

Merged
merged 3 commits into from Jul 26, 2023
Merged

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jul 25, 2023

Vitest only requires 50% of time jest requires for all tests.

This is built on top of #704 so there are more unrelated changes (see first commit).

* Drop unneeded .npmignore (`files` section of package.json overrides it anyways)
* Make package an ESM one (migrate config files to modules)
  * ESLint currently does not support an esm config, so use the json config instead
* Use `bundler` as Typescript resolution as we use rollup anyways

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux requested a review from skjnldsv July 25, 2023 16:40
@susnux susnux force-pushed the feat/vite branch 4 times, most recently from d25bd02 to ec3a11d Compare July 25, 2023 22:00
@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.94% ⚠️

Comparison is base (3dcb3ad) 100.00% compared to head (883819c) 99.06%.

❗ Current head 883819c differs from pull request most recent head 9194da7. Consider uploading reports for the commit 9194da7 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##            master     #705      +/-   ##
===========================================
- Coverage   100.00%   99.06%   -0.94%     
===========================================
  Files           10       11       +1     
  Lines          236      215      -21     
  Branches        69       70       +1     
===========================================
- Hits           236      213      -23     
- Misses           0        1       +1     
- Partials         0        1       +1     

see 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
vitest.config.ts Show resolved Hide resolved
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
@skjnldsv skjnldsv merged commit c7a12a3 into master Jul 26, 2023
8 checks passed
@skjnldsv skjnldsv deleted the feat/vite branch July 26, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants