Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PythonFileReporter: do not expect files without a filename extension to contain Python code #1489

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jayaddison
Copy link

@jayaddison jayaddison commented Nov 16, 2022

Possible fixup; could resolve #1488 (if that's confirmed to be a bug worth addressing).

@jayaddison
Copy link
Author

Awaits sphinx-doc/sphinx#11165 (or similar)

@ProsperousHeart
Copy link
Contributor

@nedbat is this still valid?

@jayaddison
Copy link
Author

It's completely possible that it'll be made redundant by other changes, @ProsperousHeart - it's a fairly innocuous warning message that most people probably won't notice (and likely rarely indicates a genuine problem).

That said: I (for no good reason) have the time and energy to follow it, even if it takes months or years, so for me it remains relevant. It's less like the Sagrada Familia and more like a small signpost that's misaligned on a minor countryside road; we're aware of it and it can be fixed at some point.

(that analogy doesn't quite make sense, because in this case we're dependent on other signposts changing elsewhere.. it's an effort to explain it, though 🤷)

@jayaddison
Copy link
Author

(a small note to mention that I continue to be interested in progressing this at some point. roughly speaking, the things on my tasklist ahead of this are: a bunch of Sphinx linkcheck-related changes (pending review, acceptance and stability assurance), before then refreshing and offering an updated Sphinx .jinja template suffix changeset, and then finally after that also being merged, accepted, proven stable -- optimistic perhaps -- then a revisit here)

@jayaddison
Copy link
Author

The Sphinx linkcheck-related changes I had in mind have been merged and release in Sphinx v7.1.0 - I'm going to wait for another week or two to allow time for any feedback and bugreports to arrive, and then I'll get started again on updating the Jinja template suffix logic... and then after that is complete, then this will be ready for reconsideration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[low-prio] Possible bug: files without extensions misidentified as Python?
2 participants