Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sphinx: copy_asset_file method templating behaviour feedback #2

Closed
jayaddison opened this issue Mar 1, 2023 · 1 comment
Closed

Comments

@jayaddison
Copy link

This is a templated and low-importance issue report; I think it's worth mentioning, but I don't mind if you disagree :)

I'm suggesting some changes to sphinx upstream in sphinx-doc/sphinx#11165 and have been looking at the possible downstream effects of using a clearer Jinja template suffix in the copy_asset_file method -- or, in fact, potentially removing the Jinja templating behaviour from that method entirely.

Please let me know if you have any thoughts on whether you feel the templating functionality should be retained, can be migrated from _t suffix to .jinja suffix, or should not be migrated at all.

A completed migration would allow coveragepy to remove a few ambiguous warning messages (see nedbat/coveragepy#1489).

Thanks!
James

@bgeron
Copy link
Owner

bgeron commented Mar 2, 2023

Hi James, thanks for your message. This extension isn't maintained any more and I'm sure it's not compatible with recent versions of Sphinx, but thanks for asking!

Cheers, Bram

@bgeron bgeron closed this as completed Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants