Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IsSame Argument Matcher #1275

Merged
merged 5 commits into from Jun 6, 2023
Merged

Add IsSame Argument Matcher #1275

merged 5 commits into from Jun 6, 2023

Conversation

ghostwriter
Copy link
Member

@ghostwriter ghostwriter commented Jun 6, 2023

This pr adds an IsSame Argument Matcher

Resolves #1268

Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
@ghostwriter ghostwriter added enhancement new feature Patch Backwards compatible bug fixes and improvements Added for new features or functionality labels Jun 6, 2023
@ghostwriter ghostwriter added this to the 1.6.2 milestone Jun 6, 2023
@ghostwriter ghostwriter self-assigned this Jun 6, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2023

Codecov Report

Merging #1275 (2b67bd8) into 1.6.x (5f62769) will decrease coverage by 0.05%.
The diff coverage is 50.00%.

❗ Current head 2b67bd8 differs from pull request most recent head ca0ea89. Consider uploading reports for the commit ca0ea89 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@             Coverage Diff              @@
##              1.6.x    #1275      +/-   ##
============================================
- Coverage     77.65%   77.60%   -0.05%     
- Complexity      998     1000       +2     
============================================
  Files            74       75       +1     
  Lines          2528     2532       +4     
============================================
+ Hits           1963     1965       +2     
- Misses          565      567       +2     
Impacted Files Coverage Δ
library/Mockery/Matcher/IsSame.php 50.00% <50.00%> (ø)

Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
@ghostwriter ghostwriter changed the title Add IsSame Matcher Add IsSame Argument Matcher Jun 6, 2023
@ghostwriter
Copy link
Member Author

Psalm failure is due to legacy code, not related to this PR.

Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
@ghostwriter ghostwriter merged commit ecadf99 into 1.6.x Jun 6, 2023
8 of 9 checks passed
@ghostwriter ghostwriter deleted the feature/matcher/is-same branch June 6, 2023 22:13
@ghostwriter ghostwriter added the Tests for updates or improvements to test suites label Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Added for new features or functionality enhancement new feature Patch Backwards compatible bug fixes and improvements Tests for updates or improvements to test suites
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants