Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate hamcrest/hamcrest-php package #1245

Merged
merged 13 commits into from May 1, 2023
Merged

Conversation

ghostwriter
Copy link
Member

@ghostwriter ghostwriter commented Apr 30, 2023

This patch is part of #1227, has the following changes:

  • Adds @trigger_error('Hamcrest package has been deprecated and will be removed in 2.0', E_USER_DEPRECATED);
  • Remove the recommendation to use Hamcrest

Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
@ghostwriter ghostwriter added deprecation something is or will be deprecated Patch Backwards compatible bug fixes and improvements labels Apr 30, 2023
@ghostwriter ghostwriter added this to the 1.6.0 milestone Apr 30, 2023
This was referenced Apr 30, 2023
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
@codecov-commenter
Copy link

codecov-commenter commented May 1, 2023

Codecov Report

Merging #1245 (98f2dc9) into 1.6.x (1f20e19) will increase coverage by 0.02%.
The diff coverage is 75.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@             Coverage Diff              @@
##              1.6.x    #1245      +/-   ##
============================================
+ Coverage     77.40%   77.43%   +0.02%     
- Complexity      993      994       +1     
============================================
  Files            74       74              
  Lines          2523     2526       +3     
============================================
+ Hits           1953     1956       +3     
  Misses          570      570              
Impacted Files Coverage Δ
library/Mockery/Matcher/MustBe.php 66.66% <ø> (ø)
library/Mockery/Configuration.php 68.57% <71.42%> (+0.92%) ⬆️
library/Mockery/Expectation.php 95.45% <100.00%> (+0.01%) ⬆️

Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
@ghostwriter ghostwriter merged commit 3587d5a into 1.6.x May 1, 2023
9 checks passed
@ghostwriter ghostwriter deleted the deprecation/hamcrest branch May 1, 2023 04:51
@ghostwriter ghostwriter added the Deprecated for features or functionality that will be removed in a future release label May 1, 2023
@ghostwriter ghostwriter self-assigned this May 6, 2023
@ruudk
Copy link
Contributor

ruudk commented Jun 5, 2023

I just noticed this deprecation. Is there a Mockery equivalent for using Hamcrest's IsEqual::equalsTo?

@ghostwriter
Copy link
Member Author

Related: #1275 and #1276

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecated for features or functionality that will be removed in a future release deprecation something is or will be deprecated Patch Backwards compatible bug fixes and improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants