Deprecate hamcrest/hamcrest-php package (#1245)

Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>

CONTRIBUTING.md

@@ -67,7 +67,7 @@ To run the unit tests for Mockery, clone the git repository, download Composer u
 the instructions at [http://getcomposer.org/download/](http://getcomposer.org/download/),
 then install the dependencies with `php /path/to/composer.phar install`.
 
-This will install the required PHPUnit and Hamcrest dev dependencies and create the
+This will install the required dev dependencies and create the
 autoload files required by the unit tests. You may run the `vendor/bin/phpunit` command
 to run the unit tests. If everything goes to plan, there will be no failed tests!
 

docs/getting_started/upgrading.rst

@@ -30,7 +30,7 @@ Read the documentation for a detailed overview of ":doc:`/reference/phpunit_inte
 +++++++++++++++++++++++++++++++++++++++++
 
 As of 1.0.0 the ``\Mockery\Matcher\MustBe`` matcher is deprecated and will be removed in
-Mockery 2.0.0. We recommend instead to use the PHPUnit or Hamcrest equivalents of the
+Mockery 2.0.0. We recommend instead to use the PHPUnit equivalents of the
 MustBe matcher.
 
 ``allows`` and ``expects``

library/Mockery/Configuration.php

@@ -253,15 +253,21 @@ public function getObjectFormatter($class, $defaultFormatter)
      */
     public function setDefaultMatcher($class, $matcherClass)
     {
-        if (!is_a($matcherClass, \Mockery\Matcher\MatcherAbstract::class, true) &&
-            !is_a($matcherClass, \Hamcrest\Matcher::class, true) &&
-            !is_a($matcherClass, \Hamcrest_Matcher::class, true)
+        $isHamcrest = is_a($matcherClass, \Hamcrest\Matcher::class, true) || is_a($matcherClass, \Hamcrest_Matcher::class, true);
+        if (
+            !is_a($matcherClass, \Mockery\Matcher\MatcherAbstract::class, true) &&
+            !$isHamcrest
         ) {
             throw new \InvalidArgumentException(
-                "Matcher class must be either Hamcrest matcher or extend \Mockery\Matcher\MatcherAbstract, " .
-                  "'$matcherClass' given."
+                "Matcher class must extend \Mockery\Matcher\MatcherAbstract, " .
+                "'$matcherClass' given."
             );
         }
+
+        if ($isHamcrest) {
+            @trigger_error('Hamcrest package has been deprecated and will be removed in 2.0', E_USER_DEPRECATED);
+        }
+
         $this->_defaultMatchers[$class] = $matcherClass;
     }
 

library/Mockery/Expectation.php

@@ -399,6 +399,8 @@ protected function _matchArg($expected, &$actual)
             return $expected->match($actual);
         }
         if ($expected instanceof \Hamcrest\Matcher || $expected instanceof \Hamcrest_Matcher) {
+            @trigger_error('Hamcrest package has been deprecated and will be removed in 2.0', E_USER_DEPRECATED);
+
             return $expected->matches($actual);
         }
         return false;

library/Mockery/Matcher/MustBe.php

@@ -21,7 +21,7 @@
 namespace Mockery\Matcher;
 
 /**
- * @deprecated 2.0 Due to ambiguity, use Hamcrest or PHPUnit equivalents
+ * @deprecated 2.0 Due to ambiguity, use PHPUnit equivalents
  */
 class MustBe extends MatcherAbstract
 {