Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow setting region via custom function #1786

Merged
merged 1 commit into from Mar 6, 2023
Merged

allow setting region via custom function #1786

merged 1 commit into from Mar 6, 2023

Conversation

harshavardhana
Copy link
Member

replaces #1783

@harshavardhana harshavardhana mentioned this pull request Mar 4, 2023
Closed
vadmeste
vadmeste approved these changes Mar 6, 2023
View reviewed changes
Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

klauspost
klauspost approved these changes Mar 6, 2023
View reviewed changes
Copy link
Contributor

@klauspost klauspost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshavardhana harshavardhana merged commit 5384d69 into minio:master Mar 6, 2023
@harshavardhana harshavardhana deleted the custom-regex branch March 6, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vadmeste vadmeste vadmeste approved these changes

@klauspost klauspost klauspost approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@harshavardhana @vadmeste @klauspost