Detect S3 region from non amazon endpoint #1782
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You should set the right region for your client constructor. We did it for AWS S3 because they have well defined domains and regions. We do not want to generalize for all endpoints. |
|
#1786 This should be what you would want here, so write your own detection patterns here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when using S3 endpoints from providers other than amazon the region is not extracted from the endpoint and the first request returns
HTTP 400withAuthorizationHeaderMalformedand the client gather the region from the XML and then retry the request with the correct region.It would be nice to extract the region from the endpoint instead of having to set it in
minio.Optionsas it's redundant when the region is already in the endpoint.