Remove dependency on Nuget.Frameworks #4693

nohwnd · 2023-09-22T13:34:17Z

Remove dependency on Nuget.Frameworks by copying the relevant code into the repository and changing namespace. The Nuget.Frameworks types were not exposed in our public API directly, but we are relying on the functionality, to parse things like net5.0, net472, or any of similar framework shorthands. We also rely on all the frameworks not being explicitly stated, e.g. net11.0 or any such verison of .NET that does not exist yet.

Replace #2544

Fix #3154

The risk here is that someone is relying on us shipping Nuget.Frameworks into the bin, and not providing it themselves.

The newly added public api should not cause issues for the existing loggers because they ship together with vstest.console.

nohwnd · 2023-09-22T13:35:21Z

src/Microsoft.TestPlatform.ObjectModel/Framework.cs

+            Version = "4.7.1.0",
+            ShortName = "net471",
+        },
+        [".NETFramework,Version=v4.7.2"] = new Framework


4.8? 4.8.1, 4.8.2?

nohwnd · 2023-09-25T11:27:27Z

eng/verify-nupkgs.ps1

@@ -16,13 +16,13 @@ function Verify-Nuget-Packages {
    $expectedNumOfFiles = @{
        "Microsoft.CodeCoverage"                      = 59;
        "Microsoft.NET.Test.Sdk"                      = 16;
-        "Microsoft.TestPlatform"                      = 607;
+        "Microsoft.TestPlatform"                      = 605;


$path = "S:\p\vstest3\artifacts\packages\Debug\Shipping"; (ls $path -re -fo | where { $_.FullName -notlike "*Symbols*" -and $_.Name -eq "Nuget.Frameworks.dll" } | % fullName) -replace [regex]::escape($path) \Microsoft.TestPlatform.17.8.0-dev\tools\net462\Common7\IDE\Extensions\TestPlatform\NuGet.Frameworks.dll \Microsoft.TestPlatform.17.8.0-dev\tools\net462\Common7\IDE\Extensions\TestPlatform\TestHostNet\NuGet.Frameworks.dll \Microsoft.TestPlatform.CLI.17.8.0-dev\contentFiles\any\netcoreapp3.1\NuGet.Frameworks.dll \Microsoft.TestPlatform.CLI.17.8.0-dev\contentFiles\any\netcoreapp3.1\TestHostNetFramework\NuGet.Frameworks.dll \Microsoft.TestPlatform.Portable.17.8.0-dev\tools\net462\NuGet.Frameworks.dll \Microsoft.TestPlatform.Portable.17.8.0-dev\tools\netcoreapp3.1\NuGet.Frameworks.dll \Microsoft.TestPlatform.Portable.17.8.0-dev\tools\netcoreapp3.1\TestHostNetFramework\NuGet.Frameworks.dll

which is count reduction by 2, 2 and 3 just like here.

nohwnd · 2023-09-25T11:51:26Z

src/Microsoft.TestPlatform.ObjectModel/PublicAPI/PublicAPI.Shipped.txt

@@ -968,3 +968,6 @@ virtual Microsoft.VisualStudio.TestPlatform.ObjectModel.TestObject.ProtectedSetP
 ~static Microsoft.VisualStudio.TestPlatform.ObjectModel.Resources.CommonResources.SourceIncompatible.get -> string
 Microsoft.VisualStudio.TestPlatform.ObjectModel.DirectoryBasedTestDiscovererAttribute
 Microsoft.VisualStudio.TestPlatform.ObjectModel.DirectoryBasedTestDiscovererAttribute.DirectoryBasedTestDiscovererAttribute() -> void
+Microsoft.VisualStudio.TestPlatform.ObjectModel.Framework.FrameworkName.get -> string!


New public api.

nohwnd · 2023-09-25T11:53:41Z

src/vstest.console/Internal/ConsoleLogger.cs

@@ -224,7 +222,7 @@ public void Initialize(TestLoggerEvents events, Dictionary<string, string?> para
        }

        parameters.TryGetValue(DefaultLoggerParameterNames.TargetFramework, out _targetFramework);
-        _targetFramework = !_targetFramework.IsNullOrEmpty() ? NuGetFramework.Parse(_targetFramework).GetShortFolderName() : _targetFramework;
+        _targetFramework = Framework.FromString(_targetFramework)?.ShortName ?? _targetFramework;


This returns null when it gets null or whitespace. The original check was unnecessary.

nohwnd · 2023-09-25T18:41:03Z

src/Microsoft.TestPlatform.ObjectModel/Framework.cs

+            {
+                // .NETPortable4.5 for example, is not a valid framework
+                // and this will throw.
+                shortName = nugetFramework.GetShortFolderName();


This throws in some cases when the framework is invalid, parsing will return it as Unsupported, but for example if we construct Portable 4.5 and don't specify Profile, it will construct it as supported, but throw when we ask for short name. We use short name as folder for logs, which we figure out when we have a "valid" runtime identifier, so keeping this null should be okay, we check for it in all the places where we use it, and supply the original value.

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [Microsoft.Identity.Web](https://togithub.com/AzureAD/microsoft-identity-web) | `2.16.1` -> `2.17.0` | [![age](https://developer.mend.io/api/mc/badges/age/nuget/Microsoft.Identity.Web/2.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/nuget/Microsoft.Identity.Web/2.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/nuget/Microsoft.Identity.Web/2.16.1/2.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/nuget/Microsoft.Identity.Web/2.16.1/2.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [Microsoft.NET.Test.Sdk](https://togithub.com/microsoft/vstest) | `17.8.0` -> `17.9.0` | [![age](https://developer.mend.io/api/mc/badges/age/nuget/Microsoft.NET.Test.Sdk/17.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/nuget/Microsoft.NET.Test.Sdk/17.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/nuget/Microsoft.NET.Test.Sdk/17.8.0/17.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/nuget/Microsoft.NET.Test.Sdk/17.8.0/17.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>AzureAD/microsoft-identity-web (Microsoft.Identity.Web)</summary> ### [`v2.17.0`](https://togithub.com/AzureAD/microsoft-identity-web/blob/HEAD/changelog.md#2170) [Compare Source](https://togithub.com/AzureAD/microsoft-identity-web/compare/2.16.1...2.17.0) \========= - Updated to Microsoft.IdentityModel.\* 7.3.1 and MSAL.NET 4.59.0 ##### New features - Added support for Microsoft.NET.Sdk.Worker. See [Worker calling APIs](https://togithub.com/AzureAD/microsoft-identity-web/wiki/worker%E2%80%90app%E2%80%90calling%E2%80%90downstream%E2%80%90apis) - Added support for Managed identity when calling a downstream API on behalf of the app. See [Calling APIs with Managed Identity](https://togithub.com/AzureAD/microsoft-identity-web/wiki/calling-apis-with-managed-identity) and [PR 2650](https://togithub.com/AzureAD/microsoft-identity-web/pull/2650). For details see [PR #2645](https://togithub.com/AzureAD/microsoft-identity-web/issues/2645) ##### Bug fixes - In OWIN applications, GetTokenForUserAsync now respects the ClaimsPrincipal. See issue [#2629](https://togithub.com/AzureAD/microsoft-identity-web/issues/2629) for details. - After setting `AddTokenAcquisition(useSingleton:true)` to use token acquisition as a singleton, if you use `.AddMicrosoftGraph` and/or `.AddDownstreamApi` after this call, the GraphServiceClient and IDownstreamApis are now registered as a singleton service. For details see [PR #2645](https://togithub.com/AzureAD/microsoft-identity-web/issues/2645) - Added check Against Injection Attacks. For details see [PR 2619](https://togithub.com/AzureAD/microsoft-identity-web/issues/2619) ##### Engineering excellence - Added a benchmark running on PR merges, available from <https://azuread.github.io/microsoft-identity-web/benchmarks> on GitHub pages </details> <details> <summary>microsoft/vstest (Microsoft.NET.Test.Sdk)</summary> ### [`v17.9.0`](https://togithub.com/microsoft/vstest/releases/tag/v17.9.0) ##### What's Changed - Remove dependency on Nuget.Frameworks by [@nohwnd](https://togithub.com/nohwnd) in [microsoft/vstest#4693 - Add platform guard by [@dotMorten](https://togithub.com/dotMorten) in [microsoft/vstest#4737 - Remove javascript in `HtmlLogger` by [@daveMueller](https://togithub.com/daveMueller) in [microsoft/vstest#4744 - Fix CPU is consumed by polling frequently when there is no subscriber by [@nohwnd](https://togithub.com/nohwnd) in [microsoft/vstest#4735 - Create a proper MSBuild ToolTask based VSTestTask by [@mcartoixa](https://togithub.com/mcartoixa) in [microsoft/vstest#2702 - Update SDK, copy logger by [@nohwnd](https://togithub.com/nohwnd) in [microsoft/vstest#4755 - Fix staircase in logger by [@nohwnd](https://togithub.com/nohwnd) in [microsoft/vstest#4756 - Update dump client to latest by [@nohwnd](https://togithub.com/nohwnd) in [microsoft/vstest#4724 - \[rel/17.9] Disable testhost prestart by [@nohwnd](https://togithub.com/nohwnd) in [microsoft/vstest#4836 ##### New Contributors - [@jithu7432](https://togithub.com/jithu7432) made their first contribution in [microsoft/vstest#4698 - [@mcartoixa](https://togithub.com/mcartoixa) made their first contribution in [microsoft/vstest#2702 **Full Changelog**: microsoft/vstest@v17.8.0...v17.9.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ThorstenSauter/NoPlan).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [Microsoft.NET.Test.Sdk](https://togithub.com/microsoft/vstest) | `17.8.0` -> `17.9.0` | [![age](https://developer.mend.io/api/mc/badges/age/nuget/Microsoft.NET.Test.Sdk/17.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/nuget/Microsoft.NET.Test.Sdk/17.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/nuget/Microsoft.NET.Test.Sdk/17.8.0/17.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/nuget/Microsoft.NET.Test.Sdk/17.8.0/17.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>microsoft/vstest (Microsoft.NET.Test.Sdk)</summary> ### [`v17.9.0`](https://togithub.com/microsoft/vstest/releases/tag/v17.9.0) ##### What's Changed - Remove dependency on Nuget.Frameworks by [@nohwnd](https://togithub.com/nohwnd) in [microsoft/vstest#4693 - Add platform guard by [@dotMorten](https://togithub.com/dotMorten) in [microsoft/vstest#4737 - Remove javascript in `HtmlLogger` by [@daveMueller](https://togithub.com/daveMueller) in [microsoft/vstest#4744 - Fix CPU is consumed by polling frequently when there is no subscriber by [@nohwnd](https://togithub.com/nohwnd) in [microsoft/vstest#4735 - Create a proper MSBuild ToolTask based VSTestTask by [@mcartoixa](https://togithub.com/mcartoixa) in [microsoft/vstest#2702 - Update SDK, copy logger by [@nohwnd](https://togithub.com/nohwnd) in [microsoft/vstest#4755 - Fix staircase in logger by [@nohwnd](https://togithub.com/nohwnd) in [microsoft/vstest#4756 - Update dump client to latest by [@nohwnd](https://togithub.com/nohwnd) in [microsoft/vstest#4724 - \[rel/17.9] Disable testhost prestart by [@nohwnd](https://togithub.com/nohwnd) in [microsoft/vstest#4836 ##### New Contributors - [@jithu7432](https://togithub.com/jithu7432) made their first contribution in [microsoft/vstest#4698 - [@mcartoixa](https://togithub.com/mcartoixa) made their first contribution in [microsoft/vstest#2702 **Full Changelog**: microsoft/vstest@v17.8.0...v17.9.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/Testably/Testably.Abstractions).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [Microsoft.NET.Test.Sdk](https://togithub.com/microsoft/vstest) | `17.8.0` -> `17.9.0` | [![age](https://developer.mend.io/api/mc/badges/age/nuget/Microsoft.NET.Test.Sdk/17.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/nuget/Microsoft.NET.Test.Sdk/17.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/nuget/Microsoft.NET.Test.Sdk/17.8.0/17.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/nuget/Microsoft.NET.Test.Sdk/17.8.0/17.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>microsoft/vstest (Microsoft.NET.Test.Sdk)</summary> ### [`v17.9.0`](https://togithub.com/microsoft/vstest/releases/tag/v17.9.0) ##### What's Changed - Remove dependency on Nuget.Frameworks by [@nohwnd](https://togithub.com/nohwnd) in [microsoft/vstest#4693 - Add platform guard by [@dotMorten](https://togithub.com/dotMorten) in [microsoft/vstest#4737 - Remove javascript in `HtmlLogger` by [@daveMueller](https://togithub.com/daveMueller) in [microsoft/vstest#4744 - Fix CPU is consumed by polling frequently when there is no subscriber by [@nohwnd](https://togithub.com/nohwnd) in [microsoft/vstest#4735 - Create a proper MSBuild ToolTask based VSTestTask by [@mcartoixa](https://togithub.com/mcartoixa) in [microsoft/vstest#2702 - Update SDK, copy logger by [@nohwnd](https://togithub.com/nohwnd) in [microsoft/vstest#4755 - Fix staircase in logger by [@nohwnd](https://togithub.com/nohwnd) in [microsoft/vstest#4756 - Update dump client to latest by [@nohwnd](https://togithub.com/nohwnd) in [microsoft/vstest#4724 - \[rel/17.9] Disable testhost prestart by [@nohwnd](https://togithub.com/nohwnd) in [microsoft/vstest#4836 ##### New Contributors - [@jithu7432](https://togithub.com/jithu7432) made their first contribution in [microsoft/vstest#4698 - [@mcartoixa](https://togithub.com/mcartoixa) made their first contribution in [microsoft/vstest#2702 **Full Changelog**: microsoft/vstest@v17.8.0...v17.9.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/apollographql/subgraph-csharp-hotchocolate-annotation).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [Microsoft.NET.Test.Sdk](https://togithub.com/microsoft/vstest) | `17.8.0` -> `17.9.0` | [![age](https://developer.mend.io/api/mc/badges/age/nuget/Microsoft.NET.Test.Sdk/17.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/nuget/Microsoft.NET.Test.Sdk/17.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/nuget/Microsoft.NET.Test.Sdk/17.8.0/17.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/nuget/Microsoft.NET.Test.Sdk/17.8.0/17.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>microsoft/vstest (Microsoft.NET.Test.Sdk)</summary> ### [`v17.9.0`](https://togithub.com/microsoft/vstest/releases/tag/v17.9.0) ##### What's Changed - Remove dependency on Nuget.Frameworks by [@nohwnd](https://togithub.com/nohwnd) in [microsoft/vstest#4693 - Add platform guard by [@dotMorten](https://togithub.com/dotMorten) in [microsoft/vstest#4737 - Remove javascript in `HtmlLogger` by [@daveMueller](https://togithub.com/daveMueller) in [microsoft/vstest#4744 - Fix CPU is consumed by polling frequently when there is no subscriber by [@nohwnd](https://togithub.com/nohwnd) in [microsoft/vstest#4735 - Create a proper MSBuild ToolTask based VSTestTask by [@mcartoixa](https://togithub.com/mcartoixa) in [microsoft/vstest#2702 - Update SDK, copy logger by [@nohwnd](https://togithub.com/nohwnd) in [microsoft/vstest#4755 - Fix staircase in logger by [@nohwnd](https://togithub.com/nohwnd) in [microsoft/vstest#4756 - Update dump client to latest by [@nohwnd](https://togithub.com/nohwnd) in [microsoft/vstest#4724 - \[rel/17.9] Disable testhost prestart by [@nohwnd](https://togithub.com/nohwnd) in [microsoft/vstest#4836 ##### New Contributors - [@jithu7432](https://togithub.com/jithu7432) made their first contribution in [microsoft/vstest#4698 - [@mcartoixa](https://togithub.com/mcartoixa) made their first contribution in [microsoft/vstest#2702 **Full Changelog**: microsoft/vstest@v17.8.0...v17.9.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/Testably/Testably.Architecture.Rules).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [Microsoft.NET.Test.Sdk](https://togithub.com/microsoft/vstest) | `17.8.0` -> `17.9.0` | [![age](https://developer.mend.io/api/mc/badges/age/nuget/Microsoft.NET.Test.Sdk/17.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/nuget/Microsoft.NET.Test.Sdk/17.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/nuget/Microsoft.NET.Test.Sdk/17.8.0/17.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/nuget/Microsoft.NET.Test.Sdk/17.8.0/17.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>microsoft/vstest (Microsoft.NET.Test.Sdk)</summary> ### [`v17.9.0`](https://togithub.com/microsoft/vstest/releases/tag/v17.9.0) ##### What's Changed - Remove dependency on Nuget.Frameworks by [@nohwnd](https://togithub.com/nohwnd) in [microsoft/vstest#4693 - Add platform guard by [@dotMorten](https://togithub.com/dotMorten) in [microsoft/vstest#4737 - Remove javascript in `HtmlLogger` by [@daveMueller](https://togithub.com/daveMueller) in [microsoft/vstest#4744 - Fix CPU is consumed by polling frequently when there is no subscriber by [@nohwnd](https://togithub.com/nohwnd) in [microsoft/vstest#4735 - Create a proper MSBuild ToolTask based VSTestTask by [@mcartoixa](https://togithub.com/mcartoixa) in [microsoft/vstest#2702 - Update SDK, copy logger by [@nohwnd](https://togithub.com/nohwnd) in [microsoft/vstest#4755 - Fix staircase in logger by [@nohwnd](https://togithub.com/nohwnd) in [microsoft/vstest#4756 - Update dump client to latest by [@nohwnd](https://togithub.com/nohwnd) in [microsoft/vstest#4724 - \[rel/17.9] Disable testhost prestart by [@nohwnd](https://togithub.com/nohwnd) in [microsoft/vstest#4836 ##### New Contributors - [@jithu7432](https://togithub.com/jithu7432) made their first contribution in [microsoft/vstest#4698 - [@mcartoixa](https://togithub.com/mcartoixa) made their first contribution in [microsoft/vstest#2702 **Full Changelog**: microsoft/vstest@v17.8.0...v17.9.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/Testably/Testably.Abstractions.FluentAssertions).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [Microsoft.NET.Test.Sdk](https://togithub.com/microsoft/vstest) | `17.8.0` -> `17.9.0` | [![age](https://developer.mend.io/api/mc/badges/age/nuget/Microsoft.NET.Test.Sdk/17.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/nuget/Microsoft.NET.Test.Sdk/17.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/nuget/Microsoft.NET.Test.Sdk/17.8.0/17.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/nuget/Microsoft.NET.Test.Sdk/17.8.0/17.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>microsoft/vstest (Microsoft.NET.Test.Sdk)</summary> ### [`v17.9.0`](https://togithub.com/microsoft/vstest/releases/tag/v17.9.0) ##### What's Changed - Remove dependency on Nuget.Frameworks by [@nohwnd](https://togithub.com/nohwnd) in [microsoft/vstest#4693 - Add platform guard by [@dotMorten](https://togithub.com/dotMorten) in [microsoft/vstest#4737 - Remove javascript in `HtmlLogger` by [@daveMueller](https://togithub.com/daveMueller) in [microsoft/vstest#4744 - Fix CPU is consumed by polling frequently when there is no subscriber by [@nohwnd](https://togithub.com/nohwnd) in [microsoft/vstest#4735 - Create a proper MSBuild ToolTask based VSTestTask by [@mcartoixa](https://togithub.com/mcartoixa) in [microsoft/vstest#2702 - Update SDK, copy logger by [@nohwnd](https://togithub.com/nohwnd) in [microsoft/vstest#4755 - Fix staircase in logger by [@nohwnd](https://togithub.com/nohwnd) in [microsoft/vstest#4756 - Update dump client to latest by [@nohwnd](https://togithub.com/nohwnd) in [microsoft/vstest#4724 - \[rel/17.9] Disable testhost prestart by [@nohwnd](https://togithub.com/nohwnd) in [microsoft/vstest#4836 ##### New Contributors - [@jithu7432](https://togithub.com/jithu7432) made their first contribution in [microsoft/vstest#4698 - [@mcartoixa](https://togithub.com/mcartoixa) made their first contribution in [microsoft/vstest#2702 **Full Changelog**: microsoft/vstest@v17.8.0...v17.9.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/bruxisma/atmosphere).  Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [Microsoft.NET.Test.Sdk](https://togithub.com/microsoft/vstest) | `17.8.0` -> `17.9.0` | [![age](https://developer.mend.io/api/mc/badges/age/nuget/Microsoft.NET.Test.Sdk/17.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/nuget/Microsoft.NET.Test.Sdk/17.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/nuget/Microsoft.NET.Test.Sdk/17.8.0/17.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/nuget/Microsoft.NET.Test.Sdk/17.8.0/17.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>microsoft/vstest (Microsoft.NET.Test.Sdk)</summary> ### [`v17.9.0`](https://togithub.com/microsoft/vstest/releases/tag/v17.9.0) ##### What's Changed - Remove dependency on Nuget.Frameworks by [@nohwnd](https://togithub.com/nohwnd) in [microsoft/vstest#4693 - Add platform guard by [@dotMorten](https://togithub.com/dotMorten) in [microsoft/vstest#4737 - Remove javascript in `HtmlLogger` by [@daveMueller](https://togithub.com/daveMueller) in [microsoft/vstest#4744 - Fix CPU is consumed by polling frequently when there is no subscriber by [@nohwnd](https://togithub.com/nohwnd) in [microsoft/vstest#4735 - Create a proper MSBuild ToolTask based VSTestTask by [@mcartoixa](https://togithub.com/mcartoixa) in [microsoft/vstest#2702 - Update SDK, copy logger by [@nohwnd](https://togithub.com/nohwnd) in [microsoft/vstest#4755 - Fix staircase in logger by [@nohwnd](https://togithub.com/nohwnd) in [microsoft/vstest#4756 - Update dump client to latest by [@nohwnd](https://togithub.com/nohwnd) in [microsoft/vstest#4724 - \[rel/17.9] Disable testhost prestart by [@nohwnd](https://togithub.com/nohwnd) in [microsoft/vstest#4836 ##### New Contributors - [@jithu7432](https://togithub.com/jithu7432) made their first contribution in [microsoft/vstest#4698 - [@mcartoixa](https://togithub.com/mcartoixa) made their first contribution in [microsoft/vstest#2702 **Full Changelog**: microsoft/vstest@v17.8.0...v17.9.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 10pm every weekday,every weekend,before 5am every weekday" in timezone Europe/Berlin, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/orso-co/Orso.Arpa.Api).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [Microsoft.NET.Test.Sdk](https://togithub.com/microsoft/vstest) | `17.8.0` -> `17.9.0` | [![age](https://developer.mend.io/api/mc/badges/age/nuget/Microsoft.NET.Test.Sdk/17.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/nuget/Microsoft.NET.Test.Sdk/17.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/nuget/Microsoft.NET.Test.Sdk/17.8.0/17.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/nuget/Microsoft.NET.Test.Sdk/17.8.0/17.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>microsoft/vstest (Microsoft.NET.Test.Sdk)</summary> ### [`v17.9.0`](https://togithub.com/microsoft/vstest/releases/tag/v17.9.0) ##### What's Changed - Remove dependency on Nuget.Frameworks by [@nohwnd](https://togithub.com/nohwnd) in [microsoft/vstest#4693 - Add platform guard by [@dotMorten](https://togithub.com/dotMorten) in [microsoft/vstest#4737 - Remove javascript in `HtmlLogger` by [@daveMueller](https://togithub.com/daveMueller) in [microsoft/vstest#4744 - Fix CPU is consumed by polling frequently when there is no subscriber by [@nohwnd](https://togithub.com/nohwnd) in [microsoft/vstest#4735 - Create a proper MSBuild ToolTask based VSTestTask by [@mcartoixa](https://togithub.com/mcartoixa) in [microsoft/vstest#2702 - Update SDK, copy logger by [@nohwnd](https://togithub.com/nohwnd) in [microsoft/vstest#4755 - Fix staircase in logger by [@nohwnd](https://togithub.com/nohwnd) in [microsoft/vstest#4756 - Update dump client to latest by [@nohwnd](https://togithub.com/nohwnd) in [microsoft/vstest#4724 - \[rel/17.9] Disable testhost prestart by [@nohwnd](https://togithub.com/nohwnd) in [microsoft/vstest#4836 ##### New Contributors - [@jithu7432](https://togithub.com/jithu7432) made their first contribution in [microsoft/vstest#4698 - [@mcartoixa](https://togithub.com/mcartoixa) made their first contribution in [microsoft/vstest#2702 **Full Changelog**: microsoft/vstest@v17.8.0...v17.9.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/cerbos/cerbos-sdk-net).  Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Oğuzhan Durgun <oguzhandurgun95@gmail.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [Microsoft.NET.Test.Sdk](https://togithub.com/microsoft/vstest) | `17.8.0` -> `17.9.0` | [![age](https://developer.mend.io/api/mc/badges/age/nuget/Microsoft.NET.Test.Sdk/17.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/nuget/Microsoft.NET.Test.Sdk/17.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/nuget/Microsoft.NET.Test.Sdk/17.8.0/17.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/nuget/Microsoft.NET.Test.Sdk/17.8.0/17.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>microsoft/vstest (Microsoft.NET.Test.Sdk)</summary> ### [`v17.9.0`](https://togithub.com/microsoft/vstest/releases/tag/v17.9.0) ##### What's Changed - Remove dependency on Nuget.Frameworks by [@nohwnd](https://togithub.com/nohwnd) in [microsoft/vstest#4693 - Add platform guard by [@dotMorten](https://togithub.com/dotMorten) in [microsoft/vstest#4737 - Remove javascript in `HtmlLogger` by [@daveMueller](https://togithub.com/daveMueller) in [microsoft/vstest#4744 - Fix CPU is consumed by polling frequently when there is no subscriber by [@nohwnd](https://togithub.com/nohwnd) in [microsoft/vstest#4735 - Create a proper MSBuild ToolTask based VSTestTask by [@mcartoixa](https://togithub.com/mcartoixa) in [microsoft/vstest#2702 - Update SDK, copy logger by [@nohwnd](https://togithub.com/nohwnd) in [microsoft/vstest#4755 - Fix staircase in logger by [@nohwnd](https://togithub.com/nohwnd) in [microsoft/vstest#4756 - Update dump client to latest by [@nohwnd](https://togithub.com/nohwnd) in [microsoft/vstest#4724 - \[rel/17.9] Disable testhost prestart by [@nohwnd](https://togithub.com/nohwnd) in [microsoft/vstest#4836 ##### New Contributors - [@jithu7432](https://togithub.com/jithu7432) made their first contribution in [microsoft/vstest#4698 - [@mcartoixa](https://togithub.com/mcartoixa) made their first contribution in [microsoft/vstest#2702 **Full Changelog**: microsoft/vstest@v17.8.0...v17.9.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/reactiveui/ReactiveUI).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [Microsoft.NET.Test.Sdk](https://togithub.com/microsoft/vstest) | `17.8.0` -> `17.9.0` | [![age](https://developer.mend.io/api/mc/badges/age/nuget/Microsoft.NET.Test.Sdk/17.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/nuget/Microsoft.NET.Test.Sdk/17.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/nuget/Microsoft.NET.Test.Sdk/17.8.0/17.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/nuget/Microsoft.NET.Test.Sdk/17.8.0/17.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>microsoft/vstest (Microsoft.NET.Test.Sdk)</summary> ### [`v17.9.0`](https://togithub.com/microsoft/vstest/releases/tag/v17.9.0) ##### What's Changed - Remove dependency on Nuget.Frameworks by [@nohwnd](https://togithub.com/nohwnd) in [microsoft/vstest#4693 - Add platform guard by [@dotMorten](https://togithub.com/dotMorten) in [microsoft/vstest#4737 - Remove javascript in `HtmlLogger` by [@daveMueller](https://togithub.com/daveMueller) in [microsoft/vstest#4744 - Fix CPU is consumed by polling frequently when there is no subscriber by [@nohwnd](https://togithub.com/nohwnd) in [microsoft/vstest#4735 - Create a proper MSBuild ToolTask based VSTestTask by [@mcartoixa](https://togithub.com/mcartoixa) in [microsoft/vstest#2702 - Update SDK, copy logger by [@nohwnd](https://togithub.com/nohwnd) in [microsoft/vstest#4755 - Fix staircase in logger by [@nohwnd](https://togithub.com/nohwnd) in [microsoft/vstest#4756 - Update dump client to latest by [@nohwnd](https://togithub.com/nohwnd) in [microsoft/vstest#4724 - \[rel/17.9] Disable testhost prestart by [@nohwnd](https://togithub.com/nohwnd) in [microsoft/vstest#4836 ##### New Contributors - [@jithu7432](https://togithub.com/jithu7432) made their first contribution in [microsoft/vstest#4698 - [@mcartoixa](https://togithub.com/mcartoixa) made their first contribution in [microsoft/vstest#2702 **Full Changelog**: microsoft/vstest@v17.8.0...v17.9.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 9pm,before 6am" in timezone Europe/Zurich, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/smartive/cas-fee-adv-mumble-api).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

remove nuget frameworks

686671d

nohwnd requested a review from MarcoRossignoli as a code owner September 22, 2023 13:34

nohwnd commented Sep 22, 2023

View reviewed changes

nohwnd marked this pull request as draft September 22, 2023 13:36

nohwnd added 3 commits September 22, 2023 15:42

Remove all mentions of nuget.frameworks

68915e7

Fix nuspec

d063458

Add one part of spec

3451050

pavelhorak mentioned this pull request Sep 22, 2023

NuGet.Frameworks dependency is causing weird test failures when trying to load MSBuild #3154

Closed

nohwnd added 4 commits September 25, 2023 12:24

Onboard nuget.frameworks code

e4adba3

Fix build

007d831

Fix build

43f296d

Fix nuget package counts

f132d95

nohwnd commented Sep 25, 2023

View reviewed changes

nohwnd changed the title ~~remove nuget frameworks~~ Remove dependency on Nuget.Frameworks Sep 25, 2023

Revert .gitignore

0bdb67f

nohwnd commented Sep 25, 2023

View reviewed changes

Remove prospective tests

a95b7f3

Evangelink approved these changes Sep 25, 2023

View reviewed changes

nohwnd added 4 commits September 25, 2023 15:01

Output version info into code

ee05e1d

Add third party notice

0701a77

unlocalize

c6dc904

Remove extra resources

f2f5465

nohwnd marked this pull request as ready for review September 25, 2023 18:37

nohwnd commented Sep 25, 2023

View reviewed changes

revert tests

6056482

nohwnd merged commit ec9a138 into microsoft:main Sep 26, 2023
6 checks passed

nohwnd deleted the remove-nuget.frameworks-try-2 branch September 26, 2023 07:44

nohwnd mentioned this pull request Sep 26, 2023

Remove nuget frameworks dependency #2544

Closed

MattKotsenas mentioned this pull request Mar 8, 2024

Could not load file or assembly 'NuGet.Frameworks, Version=6.2.1.7... jeffkl/MSBuildProjectCreator#178

Open

gao-artur mentioned this pull request Mar 13, 2024

Bump Microsoft.NET.Test.Sdk from 17.8.0 to 17.9.0 graphql-dotnet/graphql-dotnet#3914

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove dependency on Nuget.Frameworks #4693

Remove dependency on Nuget.Frameworks #4693

nohwnd commented Sep 22, 2023 •

edited

nohwnd Sep 22, 2023 •

edited

nohwnd Sep 25, 2023

nohwnd Sep 25, 2023

nohwnd Sep 25, 2023 •

edited

nohwnd Sep 25, 2023

Remove dependency on Nuget.Frameworks #4693

Remove dependency on Nuget.Frameworks #4693

Conversation

nohwnd commented Sep 22, 2023 • edited

nohwnd Sep 22, 2023 • edited

Choose a reason for hiding this comment

nohwnd Sep 25, 2023

Choose a reason for hiding this comment

nohwnd Sep 25, 2023

Choose a reason for hiding this comment

nohwnd Sep 25, 2023 • edited

Choose a reason for hiding this comment

nohwnd Sep 25, 2023

Choose a reason for hiding this comment

nohwnd commented Sep 22, 2023 •

edited

nohwnd Sep 22, 2023 •

edited

nohwnd Sep 25, 2023 •

edited