Remove nuget frameworks dependency

[nohwnd]

ℹ️ Replaced by #4693

Description

Translate short and long framework names ourselves instead of depending on Nuget.Frameworks

[nohwnd]

@vritant24 this is what I need to do to replace Nuget.Frameworks. Are you able to validate that this would fix the LUT issue?

Maybe we should add additional logic that will create a netcoreapp like Framework object from any net* string as a fallback? that way when net5.1 or net6.0 are finally added we don't have to update the class as long as they are in the form of net. I think something similar is happening in the SDK because setting the TFM to net7.99.123 will produce: The current .NET SDK does not support targeting .NET Core 7.99.123. Either target .NET Core 5.0 or lower, or use a version of the .NET SDK that supports .NET Core 7.99.123.

[nohwnd]

Huh, missing .NETFramework 47*?

[vritant24]

I'm not sure of the entire information that the testplatform has access to, but it looks like currently it is operating on TargetFramework. There is also TargetFrameworkMoniker that is much more consistent across the different runtimes.

This project system doc elaborates on that reasoning. For instance in the .NET 5 upgrade, the TargetFramework for is net5.0 but the TargetFrameworkMoniker is .NetCoreApp,Version=5.0 and didn't change from .NetCore 3.1. This suggestion is also in the .NET 5 spec

[nohwnd]

@vritant24 thanks for the tip, but imho that is relevant only to msbuild and project properties, we don't use any of those. We look at TFM attribute in the assembly, because vstest console handles only built dlls.

[MarcoRossignoli]

Looks like too stale to revive, I'm going to close(lot of conflicts and we bumped a lot of versions in these time frame).

[nohwnd]

@MarcoRossignoli that merge does not look that bad, might have a look on it when I am back.

[MarcoRossignoli]

@MarcoRossignoli that merge does not look that bad, might have a look on it when I am back.

Yep doesn't look so bad and we should catch issue with new tfm really soon in the dogfooding/insertion process.

cc: @sharwell