Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XS✔ ◾ Pipeline Compliance: Adding PoliCheck & Removing Superfluous Elements #441

Merged
merged 3 commits into from Nov 2, 2023

Conversation

muiriswoulfe
Copy link
Member

Summary

Motivation

PoliCheck was temporarily removed from the pipeline to get them into a compliant state, but this change should not be permanent.

Moreover, the pipelines now contain superfluous variables following the compliance changes.

Technical

Adding PoliCheck to the pipeline with appropriate suppressions and removing the superfluous variables.

Testing

Test Types

  • Unit tests
  • Manual tests

@muiriswoulfe muiriswoulfe added the enhancement New feature or request label Nov 2, 2023
@muiriswoulfe muiriswoulfe self-assigned this Nov 2, 2023
@muiriswoulfe muiriswoulfe requested a review from a team as a code owner November 2, 2023 19:58
Copy link
Contributor

github-actions bot commented Nov 2, 2023

PR Metrics

Thanks for keeping your pull request small.
Thanks for adding tests.

Lines
Product Code 0
Test Code 0
Subtotal 0
Ignored Code 33
Total 33

Metrics computed by PR Metrics. Add it to your Azure DevOps and GitHub PRs!

@github-actions github-actions bot changed the title Pipeline Compliance: Adding PoliCheck & Removing Superfluous Elements XS✔ ◾ Pipeline Compliance: Adding PoliCheck & Removing Superfluous Elements Nov 2, 2023
@muiriswoulfe muiriswoulfe enabled auto-merge (squash) November 2, 2023 20:09
@muiriswoulfe muiriswoulfe merged commit 617105a into main Nov 2, 2023
18 checks passed
@muiriswoulfe muiriswoulfe deleted the muiriswoulfe/pipeline-compliance-policheck branch November 2, 2023 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants