Skip to content

Commit

Permalink
XS✔ ◾ Pipeline Compliance: Adding PoliCheck & Removing Superfluous El…
Browse files Browse the repository at this point in the history
…ements (#441)

## Summary

### Motivation

PoliCheck was temporarily removed from the pipeline to get them into a
compliant state, but this change should not be permanent.

Moreover, the pipelines now contain superfluous variables following the
compliance changes.

### Technical

Adding PoliCheck to the pipeline with appropriate suppressions and
removing the superfluous variables.

## Testing

### Test Types

- [ ] Unit tests
- [X] Manual tests
  • Loading branch information
muiriswoulfe committed Nov 2, 2023
1 parent 6f35577 commit 617105a
Show file tree
Hide file tree
Showing 3 changed files with 33 additions and 9 deletions.
6 changes: 6 additions & 0 deletions .github/azure-devops/PoliCheckExclusions.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>
<PoliCheckExclusions>
<Exclusion Type="FileName">LICENSE.txt|PACKAGE-LOCK.JSON</Exclusion>
<Exclusion Type="FolderPathStart">\DIST\</Exclusion><PoliCheckExclusions>
</PoliCheckExclusions>
</PoliCheckExclusions>
3 changes: 0 additions & 3 deletions .github/azure-devops/prod.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,6 @@ extends:
name: Azure-Pipelines-1ESPT-ExDShared
os: linux
image: ubuntu-latest
variables:
- name: skipComponentGovernanceDetection
value: true
steps:
- checkout: none
displayName: Checkout
Expand Down
33 changes: 27 additions & 6 deletions .github/azure-devops/template.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,6 @@ stages:
os: macOS
image: macos-latest
variables:
- name: skipComponentGovernanceDetection
value: true
- name: System.Debug
value: true
steps:
Expand Down Expand Up @@ -63,8 +61,6 @@ stages:
os: linux
image: ubuntu-latest
variables:
- name: skipComponentGovernanceDetection
value: true
- name: System.Debug
value: true
steps:
Expand Down Expand Up @@ -94,8 +90,6 @@ stages:
os: windows
image: windows-latest
variables:
- name: skipComponentGovernanceDetection
value: true
- name: System.Debug
value: true
steps:
Expand All @@ -114,4 +108,31 @@ stages:
!dist/*
!package-lock.json
- job: Validation
displayName: Validation
pool:
${{ if parameters.testInstance }}:
vmImage: windows-latest
${{ else }}:
name: Azure-Pipelines-1ESPT-ExDShared
os: windows
image: windows-latest
steps:
- task: PoliCheck@2
displayName: PoliCheck
inputs:
targetType: F
optionsFC: 1
optionsUEPATH: $(Build.SourcesDirectory)/.github/azure-devops/PoliCheckExclusions.xml

- task: PublishSecurityAnalysisLogs@3
displayName: Guardian – Publish Artifacts

- task: PostAnalysis@2
displayName: Guardian – Perform Analysis
inputs:
GdnBreakPolicyMinSev: Note
GdnBreakGdnToolGosecSeverity: Default
GdnBreakPolicy: M365

...

0 comments on commit 617105a

Please sign in to comment.