@MeterTag does not work on package private method
#4506
Conversation
shakuzen
force-pushed
the
metertag-on-package-private-method
branch
from
7b63e9a
to
9a370e5
Compare
|
I've rebased and targeted the pull request at the |
shakuzen
changed the title
shakuzen
changed the title
@MeterTag does not work on package private method
shakuzen
added
module: micrometer-core
| @@ -89,7 +89,7 @@ public AnnotationHandler(BiConsumer<KeyValue, T> keyValueConsumer, | |||
| public void addAnnotatedParameters(T objectToModify, ProceedingJoinPoint pjp) { | |||
| try { | |||
| Method method = ((MethodSignature) pjp.getSignature()).getMethod(); | |||
| method = pjp.getTarget().getClass().getMethod(method.getName(), method.getParameterTypes()); | |||
| method = pjp.getTarget().getClass().getDeclaredMethod(method.getName(), method.getParameterTypes()); | |||
There was a problem hiding this comment.
This seems to have broken existing support for methods that are only declared in the parent class, was it intended?
There was a problem hiding this comment.
No, I don't think that was intended. Could you open an issue for it? I guess we're missing a test case to cover that scenario since we didn't notice it.
There was a problem hiding this comment.
@bpernetupgrade Ooops, no it wasn't intended and as @shakuzen says the lack of test coverage is at fault here.
Good found though, I'll see if I can provide a fix for it.
There was a problem hiding this comment.
Please take a look at #4985
Fixes
NoSuchMethodExceptionbeing thrown when using@MeterTagon package private method.