Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AnnotationHandler can't see methods from parent class #4983

Closed
bpernetupgrade opened this issue Apr 22, 2024 · 1 comment · Fixed by #4985
Closed

AnnotationHandler can't see methods from parent class #4983

bpernetupgrade opened this issue Apr 22, 2024 · 1 comment · Fixed by #4985
Labels
module: micrometer-common An issue that is related to our common module regression A regression from a previous release
Milestone
1.11.12

Comments

@bpernetupgrade
Copy link

bpernetupgrade commented Apr 22, 2024 •
edited by shakuzen

#4506 seems to have broken existing support for methods that are only declared in the parent class

We're missing a test case to cover that scenario since we didn't notice it.

Originally posted by @shakuzen in #4506 (comment)
@bpernetupgrade bpernetupgrade changed the title AnnotationHandler can't see method from upper class AnnotationHandler can't see method from parent class Apr 22, 2024
@bpernetupgrade bpernetupgrade changed the title AnnotationHandler can't see method from parent class AnnotationHandler can't see methods from parent class Apr 22, 2024
@bpernetupgrade bpernetupgrade mentioned this issue Apr 22, 2024
Merged
@shakuzen shakuzen added this to the 1.11.x milestone Apr 23, 2024
@shakuzen shakuzen added regression A regression from a previous release module: micrometer-common An issue that is related to our common module labels Apr 23, 2024
@MartinUhlen MartinUhlen mentioned this issue Apr 24, 2024
Merged
@shakuzen shakuzen modified the milestones: 1.11.x, 1.11.12 Apr 24, 2024
@shakuzen
Copy link
Member

This will be available shortly in published snapshot versions (1.11.12-SNAPSHOT, 1.12.6-SNAPSHOT, 1.13.0-SNAPSHOT) from the snapshot repo. @bpernetupgrade would you mind testing out snapshots to make sure there are no remaining issues related to this for you?
Thanks @MartinUhlen for so quickly providing a fix and a test for this.

marcingrzejszczak added a commit that referenced this issue May 7, 2024
@marcingrzejszczak
Try to read method from current class
2069e92 
gh-4983 fixed not being able to read methods from super class but it broke tracing tests
this commit tries to read method from current class but in case of method missing falls back to the default method

related to gh-4983
marcingrzejszczak added a commit that referenced this issue May 8, 2024
@marcingrzejszczak
Try to read method from current class
7c85c65 
gh-4983 fixed not being able to read methods from super class but it broke tracing tests
this commit tries to read method from current class but in case of method missing falls back to the default method

related to gh-4983
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
module: micrometer-common An issue that is related to our common module regression A regression from a previous release
Projects
None yet
Milestone
1.11.12
Development

Successfully merging a pull request may close this issue.

fix: AnnotationHandler should read annotations from parent class MartinUhlen/micrometer
2 participants
@shakuzen @bpernetupgrade