Support API Token Type from the Wavefront SDK #4102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonatan-ivanov
added
enhancement
jonatan-ivanov
commented
Sep 28, 2023
...ons/micrometer-registry-wavefront/src/main/java/io/micrometer/wavefront/WavefrontConfig.java
Show resolved
Hide resolved
oppegard
approved these changes
Sep 28, 2023
jonatan-ivanov
added
the
spring-boot change
shakuzen
approved these changes
Oct 5, 2023
|
We can handle it as a follow-up, but is there some documentation we can point to so users know the format and parts expected for the token? |
shakuzen
removed
enhancement
|
@oppegard Is there such docs? (see Tommy's question above) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API Token type was added to the Wavefront SDK so that Wavefront can support multiple types of tokens/auth mechanisms: https://github.com/wavefrontHQ/wavefront-sdk-java/releases/tag/v3.4.1