Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new CSP auth method for Wavefront (AOA) #37165

Closed
oppegard opened this issue Aug 31, 2023 · 4 comments
Closed

Support new CSP auth method for Wavefront (AOA) #37165

oppegard opened this issue Aug 31, 2023 · 4 comments
Assignees
Labels
type: enhancement A general enhancement
Milestone

Comments

@oppegard
Copy link
Contributor

Wavefront has integrated into VMware's CSP authentication system, and the wavefront-sdk-java library has been updated to support that. We would like spring-boot to support this authentication method as well.

The release version of wavefront-sdk-java with these changes is 3.4.0.

There are two types of CSP authentication: server-to-server tokens and user-api-tokens. We envision the changes looking something like this:

  • CSP User API Token

    • management.wavefront.csp.api-token
    • In WavefrontSenderConfiguration, something like new Builder(properties.getEffectiveUri().toString(), properties.getCspApiTokenOrThrow()).useTokenForCSP()
  • CSP Server to Server OAuth

    • management.wavefront.csp.client-id and management.wavefront.csp.client-secret (and an optional management.wavefront.csp.org-id)
    • In WavefrontSenderConfiguration, something like new Builder(properties.getEffectiveUri().toString(), properties.getCspClientIdOrThrow(), properties.getCspClientSecretOrThrow())
    • If the optional OrgID is provided, calling builder.cspOrgId(properties.getCspOrgIdOrThrow())

Thank you!

@oppegard and @warshawd

@scottfrederick
Copy link
Contributor

Blocked on micrometer-metrics/micrometer#4054

@scottfrederick scottfrederick added type: enhancement A general enhancement status: blocked An issue that's blocked on an external project change and removed status: waiting-for-triage An issue we've not yet triaged labels Aug 31, 2023
@scottfrederick scottfrederick added this to the 3.x milestone Aug 31, 2023
@mhalbritter
Copy link
Contributor

mhalbritter commented Oct 5, 2023

Micrometer has merged micrometer-metrics/micrometer#4102, which adds an apiTokenType on the Wavefront config. Boot needs to make this configurable through properties. Here are the changes in the Wavefront SDK: wavefrontHQ/wavefront-sdk-java#301

@mhalbritter mhalbritter removed the status: blocked An issue that's blocked on an external project change label Oct 5, 2023
@mhalbritter mhalbritter modified the milestones: 3.x, 3.2.x Oct 5, 2023
@mhalbritter mhalbritter self-assigned this Oct 5, 2023
@mhalbritter mhalbritter modified the milestones: 3.2.x, 3.2.0-RC1 Oct 5, 2023
@mhalbritter mhalbritter reopened this Oct 11, 2023
@mhalbritter
Copy link
Contributor

mhalbritter commented Oct 11, 2023

Our auto-configured WavefrontSender is now picking up the configuration property.

@mhalbritter
Copy link
Contributor

You can see the support URI formats here: wavefrontHQ/wavefront-sdk-java#301

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

4 participants