Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Keeps only the main debugbar functionality on iframes" #613

Merged
merged 1 commit into from Mar 11, 2024

Conversation

barryvdh
Copy link
Collaborator

@erikn69
Copy link
Contributor

erikn69 commented Mar 11, 2024

Maybe window.parent != window.top to prevent loops

this.hasParent = window.parent && window.parent.phpdebugbar && window.parent.phpdebugbar != this;

this.hasParent = window.parent && window.parent != window.top && window.parent.phpdebugbar && window.parent.phpdebugbar != this;

I have no way to test it, @devajmeireles could you test it??

@barryvdh
Copy link
Collaborator Author

I'll revert this until we have a chance to test this properly

@barryvdh barryvdh merged commit c7d2cfb into master Mar 11, 2024
7 checks passed
@erikn69
Copy link
Contributor

erikn69 commented Mar 11, 2024

Maybe window.parent != window.top to prevent loops
I'll revert this until we have a chance to test this properly

I was in the right direction with window.parent != window.top

when you click liveware navigator
image

But after window.parent != window.top, no more problem
image
I just didn't have enough time to test my solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants