Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keeps only the main debugbar functionality on iframes #615

Merged
merged 1 commit into from Mar 11, 2024

Conversation

erikn69
Copy link
Contributor

@erikn69 erikn69 commented Mar 11, 2024

window.parent != window.top added to prevent infinite loops(SPA, Livewire, Hotwire #613 (comment))

Alternative to #452 (comment)

We needed a way to add them to the debugbar. (a bit like it happens with ajax+headers).
The debugbar is opened in the top frame, and when something happens inside the iframes, the changes are being added to the top-level debugbar.

image
Some iframes may be hidden or small, this PR propagates data from iframes to the top main debugbar and also it prevents size errors caused by small iframes(the inside smaller iframe change web storage like height, that affects the main debugbar)

Closes #614

@erikn69
Copy link
Contributor Author

erikn69 commented Mar 11, 2024

Tested on
Hotwire => #614 (comment)
Livewire => #613 (comment)

@barryvdh barryvdh merged commit ce817fa into maximebf:master Mar 11, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InternalError: too much recursion for v1.21+
2 participants