Fix DecoderReader handling of padding #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marshallpierce
force-pushed
the
mp/decoder-reader-padding
branch
3 times, most recently
from
9fb1df0
to
89255b8
Compare
Fixes #226. DecoderReader now keeps more state so that erroneous internal padding that happens to fall right on a read buffer boundary isn't silently ignored.
marshallpierce
force-pushed
the
mp/decoder-reader-padding
branch
from
89255b8
to
57e2334
Compare
|
Hey, is there any reason why this PR should update the crate MSRV? We're using |
|
Huh, I figured that was old enough most people won't care, but I can roll that back. 1.60 is needed to build the dev dependencies, but for the main code, 1.57 is still fine. I'll release another version with that change. |
|
That would be great! Thanks :) |
|
Fix incoming in #239 |
|
0.21.2 is out with the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #226.
DecoderReader now keeps more state so that erroneous internal padding that happens to fall right on a read buffer boundary isn't silently ignored.