Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix base64 dependency error #986

Closed
notmandatory opened this issue May 23, 2023 · 3 comments · Fixed by #990
Closed

Fix base64 dependency error #986

notmandatory opened this issue May 23, 2023 · 3 comments · Fixed by #990
Assignees
@notmandatory @danielabrozzoni
Labels
bug Something isn't working
Milestone
1.0.0-alpha.1

Comments

@notmandatory
Copy link
Member

This looks like a new error that just popped up in the master and release/0.28 branches.

error: package base64 v0.21.1 cannot be built because it requires rustc 1.60.0 or newer, while the currently active rustc version is 1.57.0

see: https://github.com/bitcoindevkit/bdk/actions/runs/5018045314/jobs/9067260985?pr=957
@notmandatory notmandatory modified the milestones: 1.0.0-alpha.1, 0.28.1 May 23, 2023
@nondiremanuel nondiremanuel added the bug Something isn't working label May 23, 2023
@Sosthene00
Copy link

It seems that base64 updated it's MSRV 2 days ago: marshallpierce/rust-base64#238

@notmandatory
Copy link
Member Author

Thanks @Sosthene00 , @danielabrozzoni is working on a fix for the master branch to pin the version:
base64 = "=0.21.0". I'll do a corresponding PR for the release/0.28 branch.

@notmandatory notmandatory mentioned this issue May 24, 2023
Merged
3 tasks
@notmandatory
Copy link
Member Author

notmandatory commented May 24, 2023 •
edited

Root cause is that rust-base64 project changed their MSRV in patch release 0.21.1 from 1.57.0 to 1.60.0. I wish projects wouldn't do that but it happens.

@notmandatory notmandatory mentioned this issue May 24, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@notmandatory notmandatory

@danielabrozzoni danielabrozzoni

Labels
bug Something isn't working
Projects
BDK
Archived in project
Milestone
1.0.0-alpha.1
Development

Successfully merging a pull request may close this issue.

Pin base64 to 0.21.0 to keep the MSRV to 1.57.0 danielabrozzoni/bdk
4 participants
@notmandatory @Sosthene00 @danielabrozzoni @nondiremanuel