Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update base64 to 0.21 #127

Merged
merged 2 commits into from Aug 30, 2023
Merged

Update base64 to 0.21 #127

merged 2 commits into from Aug 30, 2023

Conversation

Ayush1325
Copy link
Contributor

Also added once_cell for caching the new Engine based APIs of base64

Signed-off-by: Ayush Singh ayushsingh1325@gmail.com

@Ayush1325
Copy link
Contributor Author

Possibly a duplicate of #123 although the versions are different.

Copy link
Member

@seanmonstar seanmonstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@seanmonstar
Copy link
Member

Ah, I guess base64 decided to use the 2021 edition, requiring a newer compiler. Sigh. What version is needed?

@Ayush1325
Copy link
Contributor Author

Ah, I guess base64 decided to use the 2021 edition, requiring a newer compiler. Sigh. What version is needed?

I think it's 1.57.0. Should I update this PR or would you like to do that separately?

@nicoxxl
Copy link

nicoxxl commented Mar 27, 2023

Beware, hyper MSRV is 1.56 : https://github.com/hyperium/hyper/blob/master/docs/MSRV.md

But 1.57.0 was released a little more than one year ago : https://blog.rust-lang.org/2021/12/02/Rust-1.57.0.html

@serprex
Copy link
Contributor

serprex commented Apr 18, 2023

@Ayush1325 please go ahead & update minrust in .github/workflows/ci.yml

@serprex
Copy link
Contributor

serprex commented Apr 23, 2023

@seanmonstar tungstenite opted to switch from base64 crate to data-encoding given how extensive latest changes are: snapview/tungstenite-rs@c6769e3

would you prefer a PR replacing base64 with data-encoding?

@serprex
Copy link
Contributor

serprex commented May 22, 2023

Looks like base64 went ahead & bumped MSRV to 1.60 with 0.21.1: marshallpierce/rust-base64#238

Created #139 as alternative to this PR

@Colerar
Copy link

Colerar commented Aug 26, 2023

Note: base64 released 0.21.3, and MSRV roll-backed to 1.48.

https://github.com/marshallpierce/rust-base64/blob/master/RELEASE-NOTES.md#0213

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@serprex
Copy link
Contributor

serprex commented Aug 28, 2023

@seanmonstar with MSRV issues seeming to be resolved for base64, can this PR progress?

@seanmonstar
Copy link
Member

Yea absolutely, let's do it :)

@seanmonstar
Copy link
Member

Huh, well looks like with httpdate, we need an MSRV of 1.56 anyways. 🤷

Cargo.toml Outdated Show resolved Hide resolved
@serprex
Copy link
Contributor

serprex commented Aug 30, 2023

Created #147 as that msrv change would be unrelated to this PR

Signed-off-by: Ayush Singh <ayushsingh1325@gmail.com>
@seanmonstar seanmonstar merged commit a8b4181 into hyperium:master Aug 30, 2023
4 checks passed
joseluisq pushed a commit to static-web-server/headers-accept-encoding that referenced this pull request Sep 16, 2023
Signed-off-by: Ayush Singh <ayushsingh1325@gmail.com>
Co-authored-by: Sean McArthur <sean@seanmonstar.com>
@serprex serprex mentioned this pull request Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants