Fix git_remote_connect not throwing on non-zero result #1913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
pushed a commit
to mendix/libgit2sharp
that referenced
this pull request
Sep 28, 2021
ghost
mentioned this pull request
ghost
pushed a commit
to mendix/libgit2sharp
that referenced
this pull request
Sep 28, 2021
* Update to libgit2 v1.3.0 and bump version * Fix git_remote_connect not throwing on non-zero result See libgit2/libgit2sharp#1913 Co-authored-by: Eoin Motherway <eoin.motherway@octopus.com>
|
Looking at this code, I'm now wondering why it only tries to dispose Regardless, this PR is an improvement, so thanks for the contribution! |
bording
approved these changes
Apr 2, 2022
|
LibGit2Sharp 0.27.0-preview-0182 includes this change. |
ghost
pushed a commit
to mendix/libgit2sharp
that referenced
this pull request
Jul 18, 2022
* Update to libgit2 v1.3.0 and bump version * Fix git_remote_connect not throwing on non-zero result See libgit2/libgit2sharp#1913 Co-authored-by: Eoin Motherway <eoin.motherway@octopus.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1912
Couldn't really find a good spot to add tests here, open to suggestions.