Improve git_remote_connect error handling

See libgit2/libgit2sharp#1913
mendix · Sep 28, 2021 · c1ae58d · c1ae58d
1 parent 5466e56
commit c1ae58d
Showing 1 changed file with 1 addition and 7 deletions.
diff --git a/LibGit2Sharp/Core/Proxy.cs b/LibGit2Sharp/Core/Proxy.cs
@@ -2154,17 +2154,11 @@ public static unsafe RemoteHandle git_remote_create_anonymous(RepositoryHandle r
 
         public static unsafe void git_remote_connect(RemoteHandle remote, GitDirection direction, ref GitRemoteCallbacks remoteCallbacks, ref GitProxyOptions proxyOptions)
         {
-            GitStrArrayManaged customHeaders = new GitStrArrayManaged();
-
-            try
+            using (var customHeaders = new GitStrArrayManaged())
             {
                 int res = NativeMethods.git_remote_connect(remote, direction, ref remoteCallbacks, ref proxyOptions, ref customHeaders.Array);
                 Ensure.ZeroResult(res);
             }
-            catch (Exception)
-            {
-                customHeaders.Dispose();
-            }
         }
 
         public static unsafe string git_remote_default_branch(RemoteHandle remote)