Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust GitStatusOptions to match structure of native libgit2 #1884

Merged
merged 1 commit into from Jun 17, 2021
Merged

Adjust GitStatusOptions to match structure of native libgit2 #1884

merged 1 commit into from Jun 17, 2021

Conversation

Molytho
Copy link
Contributor

@Molytho Molytho commented May 25, 2021

This fixes a marshaling bug that causes a segmentation fault

This mismatch caused dotdevelop's git module to crash.
More about this can be found here:
dotdevelop#2

This fixes a marshaling bug that causes a segmentation fault
@codecov-commenter
Copy link

codecov-commenter commented May 25, 2021

Codecov Report

Merging #1884 (b78b290) into master (df3b22a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1884   +/-   ##
=======================================
  Coverage   84.60%   84.61%           
=======================================
  Files         231      231           
  Lines        9174     9175    +1     
=======================================
+ Hits         7762     7763    +1     
  Misses       1412     1412           
Impacted Files Coverage Δ
LibGit2Sharp/Core/GitStatusOptions.cs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df3b22a...b78b290. Read the comment docs.

@stefanloerwald
Copy link

Can we get this merged soon? Turns out this is the reason every status query fails with the most recent dotnet runtime (5.0.7).

Thanks!
Stefan

@stefanloerwald
Copy link

Hi @bording, I'm tagging you here, because you seem to be the member of libgit2 who most recently interacted with this repository. Quite a few people are affected by this issue here. Any chance you can release a new (preview) version after merging this PR?

Thanks
Stefan

@bording bording merged commit 689dcf2 into libgit2:master Jun 17, 2021
@bording
Copy link
Member

bording commented Jun 17, 2021

This change has been published as 0.27.0-preview-0100.

@stefanloerwald
Copy link

Thank you so much, @bording. Now libgit2sharp is working again with the most recent dotnet runtime. Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants