Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LibGit2Sharp crashes on dotnet runtime 5.0.9 #6451

Closed
3 tasks
RonnyB71 opened this issue Jun 18, 2021 · 7 comments
Closed
3 tasks

LibGit2Sharp crashes on dotnet runtime 5.0.9 #6451

RonnyB71 opened this issue Jun 18, 2021 · 7 comments
Labels
blocked Status: This issue is blocked. See comments in the issue for further details. kind/bug Used when there is a defect / something is not working as it should. solution/studio/designer Issues related to the Altinn Studio Designer solution.
Milestone

Comments

@RonnyB71
Copy link
Member

RonnyB71 commented Jun 18, 2021

Describe the bug

Version 0.27.0-preview-0034, the version of LibGit2Sharp we are currently using, crashes on calls to RetrieveStatus as described here: libgit2/libgit2sharp#1884

To Reproduce

  1. Open and log in to Altinn Studio
  2. Click edit on an app
  3. Observe that the app crashes when using dotnet runtime 5.0.7 & 5.0.9 with:

An unhandled exception of type 'System.AccessViolationException' occurred in LibGit2Sharp.dll
Attempted to read or write protected memory. This is often an indication that other memory is corrupt.

Additional info

Version 0.27.0-preview-0100 is addressing this issue and we have confirmed that this resolves the problem in our case as well.

We have previously downgraded LibGit2Sharp from 0.27.0-preview-0096 to the version we are now running. We need to make sure the reason for downgrading then is addressed now and doesn't introduce new issues.

Testing

@RonnyB71 RonnyB71 added kind/bug Used when there is a defect / something is not working as it should. solution/studio/designer Issues related to the Altinn Studio Designer solution. labels Jun 18, 2021
@RonnyB71 RonnyB71 added this to the 2021 - W23/24 milestone Jun 18, 2021
@RonnyB71 RonnyB71 self-assigned this Jun 18, 2021
@lorang92
Copy link
Contributor

Duplicate of #6424 ? This is probably better described. Consider closing one of them.

@RonnyB71
Copy link
Member Author

Duplicate of #6424 ? This is probably better described. Consider closing one of them.

@lorang92 I don't think it's a duplicate. At least the error messages are different OutOfMemory vs. AccessViolationException. Might be that this update also fixes the other one, but we should verify it at least.

@mjulstein
Copy link
Contributor

Didn't @SandGrainOne find a thread that describes how how the new preview resolves some issues? Could be nice to have a link to that here :)

@RonnyB71 RonnyB71 removed their assignment Jun 22, 2021
@RonnyB71
Copy link
Member Author

Didn't @SandGrainOne find a thread that describes how how the new preview resolves some issues? Could be nice to have a link to that here :)

You mean the one linked in the description?-)

@jeevananthank
Copy link
Contributor

test is complete in staging studio on all the git operations (push, pull, delete local changes, solving merge conflicts)

@acn-sbuad
Copy link
Member

acn-sbuad commented Sep 1, 2021

Still experiencing memory issues when bumbing dotnet runtime. Others are reporting the same issues: libgit2/libgit2sharp#1872
dotnet/runtime#50739

Bumping libgit2sharp causes trouble with interacting with the repo, e.g. gettings status and push/pull

@acn-sbuad acn-sbuad added the blocked Status: This issue is blocked. See comments in the issue for further details. label Sep 1, 2021
@acn-sbuad acn-sbuad removed their assignment Sep 1, 2021
@acn-sbuad acn-sbuad changed the title LibGit2Sharp crashes on dotnet runtime 5.0.7 LibGit2Sharp crashes on dotnet runtime 5.0.9 Sep 1, 2021
@TheTechArch TheTechArch removed this from the 2021 - W34/35 milestone Sep 6, 2021
@TheTechArch TheTechArch added this to the 2021-Q3 milestone Sep 6, 2021
@acn-sbuad
Copy link
Member

Designer now running with mcr.microsoft.com/dotnet/aspnet:5.0.10-alpine3.14 AS final. Closing issue

@acn-sbuad acn-sbuad modified the milestones: 2021-Q3, 2021 - W36/37 Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Status: This issue is blocked. See comments in the issue for further details. kind/bug Used when there is a defect / something is not working as it should. solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

No branches or pull requests

8 participants