Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply PHP 8.2's SensitiveParameter attribute to Uri::withUserInfo() #116

Merged
merged 1 commit into from
Aug 30, 2022
Merged

Apply PHP 8.2's SensitiveParameter attribute to Uri::withUserInfo() #116

merged 1 commit into from
Aug 30, 2022

Commits on Aug 30, 2022

  1. Apply PHP 8.2's SensitiveParameter attribute to Uri::withUserInfo() 

    Technically the `$password` will end up in the URI anyway when stringifying it.

Adding the Attribute is simple though and absolves the reader from needing to
consider whether not having the attribute in this specific instance is safe or
not.

Signed-off-by: Tim Düsterhus <duesterhus@woltlab.com>
    @TimWolla
    TimWolla committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    9b5e106 View commit details
    Browse the repository at this point in the history