Apply PHP 8.2's SensitiveParameter attribute to Uri::withUserInfo()
#116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That likely is a bug in PHP CodeSniffer? |
Ocramius
requested changes
Aug 30, 2022
Ocramius
reviewed
Aug 30, 2022
Technically the `$password` will end up in the URI anyway when stringifying it. Adding the Attribute is simple though and absolves the reader from needing to consider whether not having the attribute in this specific instance is safe or not. Signed-off-by: Tim Düsterhus <duesterhus@woltlab.com>
TimWolla
force-pushed
the
sensitive-parameter
branch
from
e96352e
to
9b5e106
Compare
Ocramius
approved these changes
Aug 30, 2022
Ocramius
changed the title
SensitiveParameter attribute to Uri::withUserInfo()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Technically the
$passwordwill end up in the URI anyway when stringifying it.Adding the Attribute is simple though and absolves the reader from needing to
consider whether not having the attribute in this specific instance is safe or
not.
I've searched the codebase for “password“, “auth” and “secret” and this is the only place where the attribute makes sense.