Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uint256_mul_div_mod bug. #1320

Merged
merged 1 commit into from Jul 10, 2023
Merged

Conversation

alonh5
Copy link
Collaborator

@alonh5 alonh5 commented Jul 10, 2023

TITLE

Description

Description of the pull request changes and motivation.

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

@alonh5 alonh5 force-pushed the alonh/fix_uint256_mul_div_mod_bug branch from 7a40399 to 05c3b02 Compare July 10, 2023 13:22
@Oppen Oppen enabled auto-merge July 10, 2023 13:40
@github-actions
Copy link

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 3.747 ± 0.007 3.739 3.759 1.00
head big_factorial 3.781 ± 0.020 3.754 3.821 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 3.290 ± 0.016 3.257 3.310 1.00 ± 0.01
head big_fibonacci 3.285 ± 0.007 3.276 3.298 1.00
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 10.737 ± 0.027 10.704 10.775 1.00
head blake2s_integration_benchmark 10.872 ± 0.182 10.768 11.367 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 3.590 ± 0.020 3.572 3.640 1.00
head compare_arrays_200000 3.648 ± 0.023 3.618 3.679 1.02 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 2.461 ± 0.026 2.435 2.527 1.00
head dict_integration_benchmark 2.473 ± 0.005 2.466 2.483 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.923 ± 0.009 1.909 1.938 1.00
head field_arithmetic_get_square_benchmark 1.947 ± 0.022 1.925 1.985 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 9.663 ± 0.094 9.597 9.915 1.00
head integration_builtins 9.997 ± 0.436 9.636 10.988 1.03 ± 0.05
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 11.029 ± 0.141 10.880 11.305 1.00
head keccak_integration_benchmark 11.263 ± 0.062 11.141 11.359 1.02 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base linear_search 3.684 ± 0.028 3.641 3.731 1.00
head linear_search 3.734 ± 0.033 3.698 3.799 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 2.540 ± 0.008 2.528 2.553 1.00
head math_cmp_and_pow_integration_benchmark 2.562 ± 0.009 2.550 2.583 1.01 ± 0.00
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 2.364 ± 0.008 2.353 2.379 1.00
head math_integration_benchmark 2.388 ± 0.009 2.376 2.404 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 2.088 ± 0.007 2.080 2.103 1.00 ± 0.00
head memory_integration_benchmark 2.080 ± 0.007 2.071 2.094 1.00
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 2.327 ± 0.014 2.309 2.355 1.00
head operations_with_data_structures_benchmarks 2.337 ± 0.005 2.329 2.345 1.00 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 840.1 ± 1.5 838.0 842.8 1.00 ± 0.00
head pedersen 838.6 ± 1.5 837.1 841.4 1.00
Command Mean [s] Min [s] Max [s] Relative
base poseidon_integration_benchmark 1.577 ± 0.007 1.568 1.592 1.00
head poseidon_integration_benchmark 1.579 ± 0.004 1.570 1.587 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 2.727 ± 0.008 2.718 2.741 1.00
head secp_integration_benchmark 2.730 ± 0.014 2.710 2.758 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base set_integration_benchmark 1.290 ± 0.003 1.286 1.298 1.00
head set_integration_benchmark 1.297 ± 0.004 1.292 1.304 1.01 ± 0.00
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 6.932 ± 0.021 6.910 6.981 1.00 ± 0.00
head uint256_integration_benchmark 6.908 ± 0.023 6.885 6.949 1.00

@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Merging #1320 (05c3b02) into main (44dae41) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1320   +/-   ##
=======================================
  Coverage   97.88%   97.88%           
=======================================
  Files          89       89           
  Lines       35473    35473           
=======================================
  Hits        34724    34724           
  Misses        749      749           
Impacted Files Coverage Δ
..._processor/builtin_hint_processor/uint256_utils.rs 99.57% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Oppen Oppen added this pull request to the merge queue Jul 10, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 10, 2023
@pefontana pefontana added this pull request to the merge queue Jul 10, 2023
Merged via the queue into main with commit ce73104 Jul 10, 2023
34 checks passed
@pefontana pefontana deleted the alonh/fix_uint256_mul_div_mod_bug branch July 10, 2023 16:07
kariy pushed a commit to dojoengine/cairo-rs that referenced this pull request Jul 25, 2023
kariy pushed a commit to dojoengine/cairo-rs that referenced this pull request Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants