New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for uint256_mul_div_mod possible overflow #1328
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pefontana
requested review from
igaray,
Oppen,
fmoletta,
entropidelic,
juanbono and
Juan-M-V
as code owners
July 12, 2023 13:39
MegaRedHand
approved these changes
Jul 12, 2023
Benchmark Results for unmodified programs 🚀
|
Codecov Report
@@ Coverage Diff @@
## main #1328 +/- ##
==========================================
+ Coverage 97.53% 97.88% +0.35%
==========================================
Files 92 89 -3
Lines 37474 35469 -2005
==========================================
- Hits 36549 34719 -1830
+ Misses 925 750 -175 see 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Oppen
approved these changes
Jul 14, 2023
kariy
pushed a commit
to dojoengine/cairo-rs
that referenced
this pull request
Jul 25, 2023
* Add test * Fix Makefile compare commands * Fix memory holes
kariy
pushed a commit
to dojoengine/cairo-rs
that referenced
this pull request
Jul 25, 2023
* Add test * Fix Makefile compare commands * Fix memory holes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test for uint256_mul_div_mod possible overflow
Description
vm/src/tests/compare_vm_state.sh
script was outdatedChecklist