Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-0.79] WIP - Try to fix Bump Bridge CNI to fix VLAN leakage #1569

Closed
wants to merge 2 commits into from

Conversation

oshoval
Copy link
Collaborator

@oshoval oshoval commented Jun 19, 2023

What this PR does / why we need it:
This bump brings in containernetworking/plugins#875

This change is required to improve the VLAN isolation done by bridge CNI. This bump is unorthodox since it does not only cherry-pick the bug fix, but also a few other patches. This is due to the lack of a stable branch in CNI plugins. We reviewed the parasiting patches that are introduced by this bump and evaluated that they are not disruptive to our typical use of the bridge CNI.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2209318

Special notes for your reviewer:
Based on #1557
Added the last commits.

Release note:

None

phoracek and others added 2 commits June 19, 2023 11:39
This bump brings in containernetworking/plugins#875

This change is required to improve the VLAN isolation done by bridge
CNI. This bump is unorthodox since it does not only cherry-pick the bug
fix, but also a few other patches. This is due to the lack of a stable
branch in CNI plugins. We reviewed the parasiting patches that are
introduced by this bump and evaluated that they are not disruptive to
our typical use of the bridge CNI.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2209318

Signed-off-by: Petr Horacek <hrck@protonmail.com>
Signed-off-by: Or Shoval <oshoval@redhat.com>
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jun 19, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jun 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 15 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@oshoval oshoval changed the title WIP - Try to fix Bump Bridge CNI to fix VLAN leakage [release-0.79] WIP - Try to fix Bump Bridge CNI to fix VLAN leakage Jun 19, 2023
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 19, 2023
@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign phoracek for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@oshoval
Copy link
Collaborator Author

oshoval commented Jun 19, 2023

/retest

podman issues, need to bump job image for those

@oshoval
Copy link
Collaborator Author

oshoval commented Jun 19, 2023

/test pull-e2e-cnao-macvtap-cni-functests-release-0.79
/test pull-e2e-cnao-monitoring-k8s-release-0.79

@oshoval
Copy link
Collaborator Author

oshoval commented Jun 19, 2023

/test pull-e2e-cnao-macvtap-cni-functests-release-0.79
/test pull-e2e-cnao-multus-functests-release-0.79

@kubevirt-bot
Copy link
Collaborator

@oshoval: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-e2e-cnao-ovs-cni-functests-release-0.79 b4eb131 link true /test pull-e2e-cnao-ovs-cni-functests-release-0.79
pull-e2e-cnao-monitoring-k8s-release-0.79 b4eb131 link true /test pull-e2e-cnao-monitoring-k8s-release-0.79
pull-e2e-cnao-macvtap-cni-functests-release-0.79 b4eb131 link true /test pull-e2e-cnao-macvtap-cni-functests-release-0.79
pull-e2e-cnao-multus-functests-release-0.79 b4eb131 link true /test pull-e2e-cnao-multus-functests-release-0.79
pull-e2e-cnao-workflow-k8s-release-0.79 b4eb131 link true /test pull-e2e-cnao-workflow-k8s-release-0.79
pull-e2e-cnao-lifecycle-k8s-release-0.79 b4eb131 link true /test pull-e2e-cnao-lifecycle-k8s-release-0.79

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@oshoval oshoval closed this Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. release-note-none Denotes a PR that doesn't merit a release note. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants