-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-0.79] Bump Bridge CNI to fix VLAN leakage #1557
Conversation
This bump brings in containernetworking/plugins#875 This change is required to improve the VLAN isolation done by bridge CNI. This bump is unorthodox since it does not only cherry-pick the bug fix, but also a few other patches. This is due to the lack of a stable branch in CNI plugins. We reviewed the parasiting patches that are introduced by this bump and evaluated that they are not disruptive to our typical use of the bridge CNI. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2209318 Signed-off-by: Petr Horacek <hrck@protonmail.com>
/retest |
3 similar comments
/retest |
/retest |
/retest |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
/retest |
1 similar comment
/retest |
trying to fix here |
Can you please rebase ? #1571 was merged (EDIT not needed, lets try to retest first so it will auto rebase) Maybe rerun is enough as CI rebases (note that sometimes i saw we do need rebase manually, but on rare specific states, which i dont remember which exactly) /retest |
Looks good now! Thanks 1000x for fixing the CI @oshoval |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RamLavi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override pull-e2e-cnao-ovs-cni-functests-release-0.79 |
@phoracek: Overrode contexts on behalf of phoracek: pull-e2e-cnao-ovs-cni-functests-release-0.79 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
This bump brings in containernetworking/plugins#875
This change is required to improve the VLAN isolation done by bridge CNI. This bump is unorthodox since it does not only cherry-pick the bug fix, but also a few other patches. This is due to the lack of a stable branch in CNI plugins. We reviewed the parasiting patches that are introduced by this bump and evaluated that they are not disruptive to our typical use of the bridge CNI.
Special notes for your reviewer:
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2209318