Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-0.79] Bump Bridge CNI to fix VLAN leakage #1557

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

phoracek
Copy link
Member

What this PR does / why we need it:

This bump brings in containernetworking/plugins#875

This change is required to improve the VLAN isolation done by bridge CNI. This bump is unorthodox since it does not only cherry-pick the bug fix, but also a few other patches. This is due to the lack of a stable branch in CNI plugins. We reviewed the parasiting patches that are introduced by this bump and evaluated that they are not disruptive to our typical use of the bridge CNI.

Special notes for your reviewer:

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2209318

Bump bridge CNI.

This bump brings in containernetworking/plugins#875

This change is required to improve the VLAN isolation done by bridge
CNI. This bump is unorthodox since it does not only cherry-pick the bug
fix, but also a few other patches. This is due to the lack of a stable
branch in CNI plugins. We reviewed the parasiting patches that are
introduced by this bump and evaluated that they are not disruptive to
our typical use of the bridge CNI.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2209318

Signed-off-by: Petr Horacek <hrck@protonmail.com>
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels May 23, 2023
@phoracek phoracek changed the title Bump Bridge CNI to fix VLAN leakage [release-0.79] Bump Bridge CNI to fix VLAN leakage May 23, 2023
@phoracek
Copy link
Member Author

/retest

3 similar comments
@phoracek
Copy link
Member Author

/retest

@phoracek
Copy link
Member Author

/retest

@phoracek
Copy link
Member Author

/retest

@sonarcloud
Copy link

sonarcloud bot commented May 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 15 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@phoracek
Copy link
Member Author

phoracek commented Jun 1, 2023

/retest

1 similar comment
@phoracek
Copy link
Member Author

/retest

@oshoval
Copy link
Collaborator

oshoval commented Jun 19, 2023

trying to fix here
#1569

@oshoval
Copy link
Collaborator

oshoval commented Jun 22, 2023

Can you please rebase ? #1571 was merged (EDIT not needed, lets try to retest first so it will auto rebase)

Maybe rerun is enough as CI rebases (note that sometimes i saw we do need rebase manually, but on rare specific states, which i dont remember which exactly)

/retest

@phoracek
Copy link
Member Author

Looks good now! Thanks 1000x for fixing the CI @oshoval

Copy link
Collaborator

@RamLavi RamLavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 26, 2023
@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RamLavi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2023
@phoracek
Copy link
Member Author

/override pull-e2e-cnao-ovs-cni-functests-release-0.79

@kubevirt-bot
Copy link
Collaborator

@phoracek: Overrode contexts on behalf of phoracek: pull-e2e-cnao-ovs-cni-functests-release-0.79

In response to this:

/override pull-e2e-cnao-ovs-cni-functests-release-0.79

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot merged commit e5082b0 into kubevirt:release-0.79 Jun 26, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants