Mark Job onPodConditions as optional in pod failure policy #120204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
|
/sig apps |
k8s-ci-robot
added
sig/apps
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: b69b85bb35232cf6cf8ba4b71d13eb033013f337
|
|
/label api-review |
k8s-ci-robot
added
the
api-review
|
Please cherry-pick to the first version to release as beta. |
|
/lgtm please pick back to previous releases that include the field |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, mimowo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
|
Thanks! /lgtm |
|
@erikgb: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added a commit
that referenced
this pull request
Aug 28, 2023
…04-upstream-release-1.26 Automated cherry pick of #120204: Mark Job onPodConditions as optional in pod failure policy
k8s-ci-robot
added a commit
that referenced
this pull request
Aug 28, 2023
…04-upstream-release-1.28 Automated cherry pick of #120204: Mark Job onPodConditions as optional in pod failure policy
k8s-ci-robot
added a commit
that referenced
this pull request
Aug 28, 2023
…04-upstream-release-1.27 Automated cherry pick of #120204: Mark Job onPodConditions as optional in pod failure policy
k8s-ci-robot
added a commit
that referenced
this pull request
Aug 28, 2023
…04-upstream-release-1.25 Automated cherry pick of #120204: Mark Job onPodConditions as optional in pod failure policy
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind api-change
What this PR does / why we need it:
To make onPodConditions optional, to align it with the intention reflected in the comment:
One of onExitCodes and onPodConditions, but not both, can be used in each rule.. Also, to align the annotations with the validation code: https://github.com/kubernetes/kubernetes/blob/master/pkg/apis/batch/validation/validation.go#L324-L329Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: