Upgrade Kubernetes schema and libraries to v1.29 #2690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2690 +/- ##
==========================================
- Coverage 18.41% 18.40% -0.01%
==========================================
Files 47 47
Lines 9589 9593 +4
==========================================
Hits 1766 1766
- Misses 7724 7728 +4
Partials 99 99 ☔ View full report in Codecov by Sentry. |
rquitales
force-pushed
the
rquitales/update-k8s-1.29
branch
from
3d703a7
to
a0947a8
Compare
EronWright
reviewed
Dec 7, 2023
rquitales
force-pushed
the
rquitales/update-k8s-1.29
branch
from
a0947a8
to
bd5dfe7
Compare
rquitales
force-pushed
the
rquitales/update-k8s-1.29
branch
from
bd5dfe7
to
900da0e
Compare
rquitales
force-pushed
the
rquitales/update-k8s-1.29
branch
from
900da0e
to
364009a
Compare
rquitales
force-pushed
the
rquitales/update-k8s-1.29
branch
from
364009a
to
ad58335
Compare
|
The 3 breaking changes should be relatively safe for our users:
^ These were updated in kubernetes/api@8b14183. This seems like a safe change since the previous type is incorrect for volumes as it doesn't require the
^ This was marked as optional in this upstream PR: kubernetes/kubernetes#120204, and will be back ported to older minor k8s releases. |
Kubernetes v1.29 will stop serving v1beta2 of the flow control API group. There were some spec changes in this API group from Kubernetes v1.26 and v1.28, so we will also need to fetch v1.28 of the OpenAPI spec for merging.
rquitales
force-pushed
the
rquitales/update-k8s-1.29
branch
from
ad58335
to
6e8cbc0
Compare
rquitales
changed the title
|
Waiting on client libraries to be tagged and released. AFAICT the final release of v1.29.0 should be identical to v1.29.0-rc.2. Will leave the changelog entry check as a merge blocker until this PR is updated to use the final release version of the client libraries. |
EronWright
approved these changes
Dec 13, 2023
Commands run:
```
cd provider/
go get -u github.com/pulumi/cloud-ready-checks@v1.1.0
cat go.mod | grep "^\sk8s.io" | grep -v "// indirect" | awk '{print $1}' | xargs -I {} go get -u {}@v0.29.0
go mod tidy
```
Commands run: ``` make ensure ```
rquitales
force-pushed
the
rquitales/update-k8s-1.29
branch
from
6e8cbc0
to
531a9d1
Compare
Does the PR have any schema changes?Found 3 breaking changes: Types
New resources:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Update Kubernetes schema and libraries to v1.29.0.
Related issues (optional)
Fixes: #2628