Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Windows support for InPlace Pod Vertical Scaling #112599

Merged
merged 2 commits into from Oct 31, 2023
Merged

Adding Windows support for InPlace Pod Vertical Scaling #112599

merged 2 commits into from Oct 31, 2023

Conversation

fabi200123
Copy link
Contributor

@fabi200123 fabi200123 commented Sep 20, 2022 •
edited

What type of PR is this?

/kind feature
/sig Windows

What this PR does / why we need it:

It adds Windows support for the In-place Pod Vertical Scaling feature.

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Added Windows support for InPlace Pod Vertical Scaling feature.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
[FEATURE]: #102884

/cc @claudiubelu

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. sig/windows Categorizes an issue or PR as relevant to SIG Windows. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 20, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @fabi200123. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. labels Sep 20, 2022
@fabi200123 fabi200123 changed the title Adding Windows support for InPlaceVerticalScaling Adding Windows support for InPlace Pod Vertical Scaling Sep 20, 2022
@SergeyKanzhelev
Copy link
Member

@fabi200123 please include the release notes section to the pr description

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 20, 2022
@SergeyKanzhelev SergeyKanzhelev moved this from Triage to Needs Reviewer in SIG Node PR Triage Sep 20, 2022
@marosset
Copy link
Contributor

/milestone v1.26

@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Sep 22, 2022
@salaxander
Copy link

Hey @fabi200123 @marosset - 1.26 bug triage team checking in! Just wanted to see if we're on track to get this in for the 1.26 release?

Thanks!

@vinaykul
Copy link
Contributor

vinaykul commented Oct 6, 2022

@fabi200123 Thanks for working on adding Windows support for In-Place Resize. Since this can be directly targeted to main branch, can I close your PR targeting my mothership PR 102884?

@fabi200123
Copy link
Contributor Author

Yes, you can close this!

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 2, 2022
@leonardpahlke leonardpahlke removed this from the v1.26 milestone Nov 9, 2022
@marosset
Copy link
Contributor

It looks like vinaykul#16 is closed.
Should we cherry-pick this and include it in #102884?

@k8s-ci-robot k8s-ci-robot removed sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/security Categorizes an issue or PR as relevant to SIG Security. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Oct 30, 2023
@marosset
Copy link
Contributor

/remove-area apiserver code-generation dependency ipvs kubectl provider/gcp release-eng

@k8s-ci-robot k8s-ci-robot removed area/apiserver area/code-generation area/dependency Issues or PRs related to dependency changes area/ipvs area/kubectl area/provider/gcp Issues or PRs related to gcp provider area/release-eng Issues or PRs related to the Release Engineering subproject labels Oct 30, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabi200123, mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2023
@mrunalp
Copy link
Contributor

mrunalp commented Oct 31, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 31, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 895e77dbf7ce9101ef3c78efd121f80c3ca538bd

@k8s-ci-robot k8s-ci-robot merged commit dea3f1a into kubernetes:master Oct 31, 2023
18 checks passed
SIG Node PR Triage automation moved this from Needs Reviewer to Done Oct 31, 2023
saschagrunert added a commit to saschagrunert/kubernetes that referenced this pull request Nov 16, 2023
@saschagrunert
Enable pod container resources tests on Windows
2076429 
PR kubernetes#112599 merged so it
seems that we can now enable the tests on Windows.

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@saschagrunert saschagrunert mentioned this pull request Nov 16, 2023
Merged
aramase pushed a commit to aramase/kubernetes that referenced this pull request Feb 8, 2024
@saschagrunert @aramase
Enable pod container resources tests on Windows
b8e0340 
PR kubernetes#112599 merged so it
seems that we can now enable the tests on Windows.

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
dinhxuanvu pushed a commit to dinhxuanvu/kubernetes that referenced this pull request Mar 28, 2024
@saschagrunert @dinhxuanvu
Enable pod container resources tests on Windows
183ffbd 
PR kubernetes#112599 merged so it
seems that we can now enable the tests on Windows.

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
ah8ad3 pushed a commit to ah8ad3/kubernetes that referenced this pull request Apr 6, 2024
@saschagrunert @ah8ad3
Enable pod container resources tests on Windows
e37d8cb 
PR kubernetes#112599 merged so it
seems that we can now enable the tests on Windows.

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrunalp mrunalp mrunalp approved these changes

@claudiubelu claudiubelu Awaiting requested review from claudiubelu

@jsturtevant jsturtevant Awaiting requested review from jsturtevant

@marosset marosset Awaiting requested review from marosset

@SergeyKanzhelev SergeyKanzhelev Awaiting requested review from SergeyKanzhelev

@vinaykul vinaykul Awaiting requested review from vinaykul

Assignees

@mrunalp mrunalp

@jsturtevant jsturtevant

@claudiubelu claudiubelu

@SergeyKanzhelev SergeyKanzhelev

@vinaykul vinaykul

@marosset marosset

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Apps
Archived in project
SIG Auth
Archived in project
SIG CLI
Archived in project
SIG Node CI/Test Board
Archive-it
SIG Node CI/Test Board
Archived in project
SIG Node PR Triage
Done
SIG Scheduling
Archived in project
[sig-release] Bug Triage
Archived in project
[sig-windows] PR tracking
Status: Done
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.

None yet