-
Notifications
You must be signed in to change notification settings - Fork 38.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable pod container resources tests on Windows #121923
Enable pod container resources tests on Windows #121923
Conversation
PR kubernetes#112599 merged so it seems that we can now enable the tests on Windows. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
/test pull-kubernetes-unit |
2 similar comments
/test pull-kubernetes-unit |
/test pull-kubernetes-unit |
/triage accepted /assign @mrunalp @dchen1107 @derekwaynecarr |
LGTM label has been added. Git tree hash: 8e36199071e6506c27f062887484c78f61abae5c
|
/approve (happy to enable these tests, no logic change other than allowing windows nodes) |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
/hold |
/unhold |
/test pull-kubernetes-node-e2e-containerd |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
PR #112599 merged so it seems that we can now enable the tests on Windows.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
cc @claudiubelu
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: